-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
error building on ubuntu 14.04 #293
Comments
do you know what the problem is? |
Well, your output tells precisely what the problem is. Compilation fails because of the warnings, which were made to be treated as errors with Just add |
shouldn't the problem be fix in the source? |
Yeah, the build system should be fixed. |
@zoff99 does the compilation still fail if you do a clean build with the line containing |
cmake -DWARNINGS=OFF works. |
Yes, the code which triggers these warnings should be fixed. No, this is not the code that deals with the crypto, toxav only handles audio/video. Also, even if all the warnings are fixed in the code, the compilation would still fail because of the unrecognized warning flags, so fixing the code alone is not enough. @iphydf can we somehow query the compiler if it supports a certain warning flag? |
Hm, interesting, it looks like |
maybe the gcc version is old on circleCI ? do you need a specific version of GCC ? |
@iphydf is the guy to ask this about. |
We build the library on Travis CI with gcc 4.6.3 and clang 3.4, there are no warnings produced during the builds. |
What version of gcc does circleCI use? |
I also don't get any warnings with gcc version 4.9.2 (Debian 4.9.2-10). |
gcc (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4 |
how do i get the clang version? |
Just pass |
ok then clang is not installed :-) |
Why would that be an issue? clang is just a different compiler. |
clang --version ; exit 1 bash: line 1: clang: command not found clang --version ; exit 1 returned exit code 1 Action failed: clang --version ; exit 1 |
ok. now this looks better: Ubuntu clang version 3.4-1ubuntu3 (tags/RELEASE_34/final) (based on LLVM 3.4) |
Did you compile with clang instead of gcc this time? |
when compiling with clang the errors are gone. |
thanks for the help, guys |
now the network test fails on CI. is there anything special that needs to be installed/setup for that test?
all details: |
See the output of the tests as to why it has failed. Also, why are you setting up CircleCI for toxcore? We already have a quite complicated TravisCI setup which we maintain, it compiles toxcore for windows, os x and linux, in linux's case it does so against several compilers and using both builds systems toxcore supports. You could just used the already existing TravisCI setup. |
circleCI has a few advantages. but anyhow, i should be able to do this without much fuzz. |
Hm, in your GitHub history I see you are making a lot of single contributions to different Android projects, mostly just adding CircleCI integration for them. If you want to add CircleCI for toxcore, you probably should have created an issue about it first, asking if that's something we would want. |
actually in this case i don't. i am trying to compile 2 projects from source which require toxcore. so i start with toxcore |
A bit of off-topic, just some advises based on your GitHub profile. I see that you do a lot of small messy commits with uninformative commit messages like "fix", "fix 2", "fix 3" and you do them by the most part from the GitHub web interface (the commits have "committed on GitHub"). Firstly, you should try to have a single commit per a meaningfully complete change. The many "fix" commits you have could have been combined into a single commit. Secondly, the commit messages should be meaningful, e.g. "Add CircleCI integration" instead of just "add" or "fix". Thirdly, you should really learn how to use the command line git program, or at least some GUI around it. This would allow you to squash multiple commits together, which is useful if you realize that your previous commit didn't do the job and you want to add more to it, like in the case of "fix", "fix 2", "fix 3", it also allows to modify commit messages and much more. Fourthly, you also seem to keep forks of some repositories and update those forks with upstream by making PRs to your forks with the changes from upstream, creating merge commits. That's a very weird way of keeping your forks up-to-date with upstream, you could have done so with the git command line program in 2 commands and you would avoid any merge commits, i.e. your fork would be completely identical with the upstream repository, but the way you do it you have merge commits for your own PRs. |
@iphydf any idea why gcc 4.8.4 on Ubuntu 14.04 was giving @zoff99 warnings in toxav (see the initial post in this thread)? If there are warning in toxav, we got to fix them. Also, any idea and why cmake was passing unsupported warning flags to the compiler (see the initial post in this thread), while I didn't get any warnings on gcc 4.9.2? Do |
the problem is at building toxav:
see my build commands here:
https://circleci.com/gh/zoff99/c-toxcore/7
The text was updated successfully, but these errors were encountered: