Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the current tests exercise both ipv4 and ipv6. #22

Closed
iphydf opened this issue Aug 9, 2016 · 2 comments
Closed

Make the current tests exercise both ipv4 and ipv6. #22

iphydf opened this issue Aug 9, 2016 · 2 comments
Assignees
Labels
P3 Low priority
Milestone

Comments

@iphydf
Copy link
Member

iphydf commented Aug 9, 2016

Disable ipv6 on travis if it breaks too often, but have at least one test that exercises both paths.

@GrayHatter
Copy link

@iphydf should we close this issue?

I'm leaning more towards your idea of a virtual network interface for testing. And then optionally, we can do profiling across IPv4/6 when/if needed?

@iphydf
Copy link
Member Author

iphydf commented Oct 16, 2016

Sounds good. Network tests aren't unit tests anyway, and we should have integration tests for all network situations we can simulate or create at some point.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Low priority
Projects
None yet
Development

No branches or pull requests

2 participants