Provide official signed release tarballs

[kotelnik]

I'm unable to build the project on debian 11 (configure / cmake phase) since commit ee154da.

Log:

$ cmake ..
-- The C compiler identification is GNU 10.2.1
-- The CXX compiler identification is GNU 10.2.1
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
SOVERSION: 2.17.0
-- Found PkgConfig: /usr/bin/pkg-config (found version "0.29.2")
-- Supported C compiler features = c_std_90;c_function_prototypes;c_std_99;c_restrict;c_variadic_macros;c_std_11;c_static_assert
-- Supported C++ compiler features = cxx_std_98;cxx_template_template_parameters;cxx_std_11;cxx_alias_templates;cxx_alignas;cxx_alignof;cxx_attributes;cxx_auto_type;cxx_constexpr;cxx_decltype;cxx_decltype_incomple
te_return_types;cxx_default_function_template_args;cxx_defaulted_functions;cxx_defaulted_move_initializers;cxx_delegating_constructors;cxx_deleted_functions;cxx_enum_forward_declarations;cxx_explicit_conversions;c
xx_extended_friend_declarations;cxx_extern_templates;cxx_final;cxx_func_identifier;cxx_generalized_initializers;cxx_inheriting_constructors;cxx_inline_namespaces;cxx_lambdas;cxx_local_type_template_args;cxx_long_l
ong_type;cxx_noexcept;cxx_nonstatic_member_init;cxx_nullptr;cxx_override;cxx_range_for;cxx_raw_string_literals;cxx_reference_qualified_functions;cxx_right_angle_brackets;cxx_rvalue_references;cxx_sizeof_member;cxx
_static_assert;cxx_strong_enums;cxx_thread_local;cxx_trailing_return_types;cxx_unicode_literals;cxx_uniform_initialization;cxx_unrestricted_unions;cxx_user_literals;cxx_variadic_macros;cxx_variadic_templates;cxx_s
td_14;cxx_aggregate_default_initializers;cxx_attribute_deprecated;cxx_binary_literals;cxx_contextual_conversions;cxx_decltype_auto;cxx_digit_separators;cxx_generic_lambdas;cxx_lambda_init_captures;cxx_relaxed_cons
texpr;cxx_return_type_deduction;cxx_variable_templates;cxx_std_17;cxx_std_20
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Failed
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - found
-- Found Threads: TRUE
-- Checking for one of the modules 'libsodium'
-- Checking for one of the modules 'opus'
-- Checking for one of the modules 'vpx'
-- Checking for one of the modules 'libconfig'
CMAKE_THREAD_LIBS_INIT: -lpthread
-- Checking for gtest
-- Configuring done
CMake Error at cmake/ModulePackage.cmake:67 (add_library):
  Cannot find source file:

    third_party/cmp/cmp.c

  Tried extensions .c .C .c++ .cc .cpp .cxx .cu .m .M .mm .h .hh .h++ .hm
  .hpp .hxx .in .txx
Call Stack (most recent call first):
  CMakeLists.txt:387 (add_module)


CMake Error at cmake/ModulePackage.cmake:67 (add_library):
  No SOURCES given to target: toxcore_static
Call Stack (most recent call first):
  CMakeLists.txt:387 (add_module)


CMake Error at cmake/ModulePackage.cmake:63 (add_library):
  No SOURCES given to target: toxcore_shared
Call Stack (most recent call first):
  CMakeLists.txt:387 (add_module)


CMake Generate step failed.  Build files cannot be regenerated correctly.

Thanks for your code! :)

[Green-Sky]

There is now a git submodule, so you either have to clone with --recursive, or run git submodule update --init after cloning.

[kotelnik]

Ups, sorry, my bad. Closing :) And thanks a lot! :)

[omar-polo]

I'm having the same issue building the latest release from the github-provided tarball. third_party/cmp/ inside the tarball is empty.

Many distributions are using the github-provided tarball to build (at least that's the case for the OpenBSD package which I was trying to update.) It's possible to work around it, but it'd be uglier and I thought of letting you know.

P.S.: providing an official tarball with all the sources would be really appreciated! :)

[iphydf]

I thought we already did that. @robinlinden do the release tarballs contain cmp?

[robinlinden]

Ah, no, I guess we need to package the tarballs ourselves now that we have submodules. Until now we've been relying on the automatically generated ones. I'll upload a new one with cmp added.

[Geremia]

@robinlinden Have you uploaded it yet?

[robinlinden]

The tarballs w/ cmp are up now: https://github.com/TokTok/c-toxcore/releases/tag/v0.2.18
The old signatures were replaced with ones for the new artifacts.

[omar-polo]

Thanks!

[Geremia]

@robinlinden I still get the "Cannot find source file: third_party/cmp/cmp.c #2305" issue with https://github.com/TokTok/c-toxcore/archive/v0.2.18/c-toxcore-0.2.18.tar.gz (MD5SUM: c30e174677ef75faea31b7217974f494).

[iphydf]

Indeed the file is not in the tarball.

[omar-polo]

That's still the tarball auto-generated by github. They do not contain the git submodules.

Fetch the manually uploaded tarball here: https://github.com/TokTok/c-toxcore/releases/download/v0.2.18/c-toxcore-0.2.18.tar.gz

(it's the first one in the "Assets" listing in https://github.com/TokTok/c-toxcore/releases/tag/v0.2.18) and that contains all the sources :)