Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sodium autotools CI build #2014

Closed
nurupo opened this issue Feb 9, 2022 · 1 comment
Closed

Add sodium autotools CI build #2014

nurupo opened this issue Feb 9, 2022 · 1 comment
Labels
chore Updating grunt tasks etc; no production code change P3 Low priority
Milestone

Comments

@nurupo
Copy link
Member

nurupo commented Feb 9, 2022

Currently we test nacl autotools builds on CI, but it builds just a static libtoxcore.a. Having a sodium autotools build would test both static and shared builds (it builds both), which would help us find issues that appear only during shared library building, like #2009 and #2015.

@nurupo nurupo added the chore Updating grunt tasks etc; no production code change label Feb 9, 2022
@nurupo nurupo added this to the v0.2.17 milestone Feb 9, 2022
@nurupo nurupo added the P3 Low priority label Feb 9, 2022
@iphydf iphydf removed their assignment Feb 18, 2022
@iphydf iphydf modified the milestones: v0.2.17, v0.2.19, v0.2.18 Feb 28, 2022
@iphydf iphydf modified the milestones: v0.2.18, v0.2.19 Apr 7, 2022
@iphydf iphydf modified the milestones: v0.2.19, v0.2.20 Nov 10, 2023
@iphydf iphydf modified the milestones: v0.2.20, v0.2.19 Feb 13, 2024
@iphydf
Copy link
Member

iphydf commented Feb 13, 2024

We've removed nacl and the autotools build uses sodium now.

@iphydf iphydf closed this as completed Feb 13, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Updating grunt tasks etc; no production code change P3 Low priority
Projects
None yet
Development

No branches or pull requests

2 participants