Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace astyle by clang-format #136

Closed
iphydf opened this issue Sep 13, 2016 · 2 comments
Closed

Replace astyle by clang-format #136

iphydf opened this issue Sep 13, 2016 · 2 comments
Labels
P3 Low priority
Milestone

Comments

@iphydf
Copy link
Member

iphydf commented Sep 13, 2016

Astyle is rather limited, and behaves differently in different versions. Create a .clang-format file that ideally produces a minimal diff from the current formatting. Create two PRs: one with changes that affect lines (git diff -w > my.patch; git checkout .; patch -p1 < my.patch), and another on top of that with the remaining changes (git diff -w shows an empty diff).

@GrayHatter GrayHatter removed their assignment Sep 14, 2016
@GrayHatter
Copy link

I've unassigned myself because I need to take some time off, and this is an easy one anyone can learn to do pretty quickly.

Feel free to ping me if you need support, or I'll pick this one back up when I can.

@nurupo
Copy link
Member

nurupo commented Sep 14, 2016

behaves differently in different versions

That's not true for clang-format?

@iphydf iphydf closed this as completed Sep 22, 2016
@iphydf iphydf modified the milestone: v0.0.1 Nov 5, 2016
@iphydf iphydf added the P3 Low priority label Feb 4, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Low priority
Projects
None yet
Development

No branches or pull requests

3 participants