-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save file corruption #1275
Comments
I'm creating a new Creating an array with There were no runtime errors in this process, otherwise I would have seen them logged, and neither has this ever happened with |
* Tuesday, 2018-12-04 at 01:06 -0800 - naxuroqa <[email protected]>:
Yesterday I was experimenting with the latest version of toxcore from
git/master and in about one out of ten times of saving the data file,
it got corrupted and could not be loaded anymore.
That's worrying. More precise information would be helpful. One question
which would might narrow it down: were you using groups at all when you
ran into save corruption?
|
@zugz I was, that's why I tried it out :) Is there anything I can do to provide you with more info? I can try to get a savefile to corrupt and send it to you if that helps. |
* Tuesday, 2018-12-04 at 09:38 -0800 - naxuroqa <[email protected]>:
I can try to get a savefile to corrupt and send it to you if that
helps.
That would definitely help!
|
does analyzing make sense? we should merge #1242 before that. i don't understand what the holdup is there? |
Actually, I think I see what must be going on. If I'm right, it should
be fixed in #1267.
My theory is that the problem was that your public key somehow ended up
appearing twice in the list of peers and frozen peers, with different
peer numbers. That shouldn't be possible in #1267, but in current master
it could have happened if you accepted two different invites to the same
group, for example. The saving code implicitly assumed that this didn't
happen, and wrote something unloadable if it did. I've just pushed
a commit to #1267 which removes that assumption.
So: could you try #1267 and report back, preferably with a corrupted
save file, if you run into a problem again?
Thanks for the report, in any case!
|
* Tuesday, 2018-12-04 at 18:54 +0000 - Zoff <[email protected]>:
does analyzing make sense? we should merge #1242 before that.
It looks like this one was my fault, so probably nothing to do with
#1242.
|
This should be fixed with 0.2.9, right? can anyone confirm? |
@sudden6 I'll see if 0.2.9 fixed it, will close if it doesn't occur anymore. |
Fixed for me, tested pre and post fix: #1267 (comment) |
oh, nice. So it was only partially corrupted? You are right, I can't reproduce the corruption anymore. |
Yesterday I was experimenting with the latest version of toxcore from git/master and in about one out of ten times of saving the data file, it got corrupted and could not be loaded anymore. I'll try to get some more info about what exactly fails to be restored, for now I just wanted to find out if somebody else experienced this.
This never happened to me with 0.2.8, so I think that's a regression.
toxcore version: 9770880
The text was updated successfully, but these errors were encountered: