From 203e1af81e48909f0a6647fcbe6fc5d4764187bd Mon Sep 17 00:00:00 2001 From: jfreegman Date: Thu, 25 Jan 2024 11:08:35 -0500 Subject: [PATCH] fix: a few off by one errors in group autotests Since we're nul terminating these buffers they need one extra byte --- auto_tests/group_moderation_test.c | 4 ++-- auto_tests/group_state_test.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/auto_tests/group_moderation_test.c b/auto_tests/group_moderation_test.c index a0d75d6b9a..e7fae5ce4c 100644 --- a/auto_tests/group_moderation_test.c +++ b/auto_tests/group_moderation_test.c @@ -19,13 +19,13 @@ #define GROUP_NAME_LEN (sizeof(GROUP_NAME) - 1) typedef struct Peer { - char name[TOX_MAX_NAME_LENGTH]; + char name[TOX_MAX_NAME_LENGTH + 1]; size_t name_length; uint32_t peer_id; } Peer; typedef struct State { - char self_name[TOX_MAX_NAME_LENGTH]; + char self_name[TOX_MAX_NAME_LENGTH + 1]; size_t self_name_length; uint32_t group_number; diff --git a/auto_tests/group_state_test.c b/auto_tests/group_state_test.c index ca9532387b..866c10a553 100644 --- a/auto_tests/group_state_test.c +++ b/auto_tests/group_state_test.c @@ -179,7 +179,7 @@ static int check_group_state(const Tox *tox, uint32_t groupnumber, uint32_t peer if (password != nullptr && my_pass_len > 0) { ck_assert(my_pass_len <= TOX_GROUP_MAX_PASSWORD_SIZE); - uint8_t my_pass[TOX_GROUP_MAX_PASSWORD_SIZE]; + uint8_t my_pass[TOX_GROUP_MAX_PASSWORD_SIZE + 1]; tox_group_get_password(tox, groupnumber, my_pass, &query_err); my_pass[my_pass_len] = 0; ck_assert_msg(query_err == TOX_ERR_GROUP_STATE_QUERIES_OK, "Failed to get password: %d", query_err); @@ -199,7 +199,7 @@ static int check_group_state(const Tox *tox, uint32_t groupnumber, uint32_t peer ck_assert(my_gname_len <= TOX_GROUP_MAX_GROUP_NAME_LENGTH); - uint8_t my_gname[TOX_GROUP_MAX_GROUP_NAME_LENGTH]; + uint8_t my_gname[TOX_GROUP_MAX_GROUP_NAME_LENGTH + 1]; tox_group_get_name(tox, groupnumber, my_gname, &query_err); my_gname[my_gname_len] = 0;