fix: remove findAllRotations default value

Author: Jiwon-Woo

Diff for: src/rotation/dto/find-rotation-query.dto.ts

@@ -3,8 +3,6 @@ import { Transform } from 'class-transformer';
 import { IsNumber, IsOptional, Max, Min } from 'class-validator';
 
 export class FindRotationQueryDto {
-  private currentDate = new Date();
-
   @Transform((params) => +params.value)
   @ApiProperty({
     required: false,
@@ -15,7 +13,7 @@ export class FindRotationQueryDto {
   @IsNumber()
   @Min(1)
   @Max(12)
-  month?: number = this.currentDate.getMonth() + 1;
+  month?: number;
 
   @Transform((params) => +params.value)
   @ApiProperty({
@@ -27,5 +25,5 @@ export class FindRotationQueryDto {
   @IsNumber()
   @Min(2020)
   @Max(2100)
-  year?: number = this.currentDate.getFullYear();
+  year?: number;
 }

Diff for: src/rotation/rotations.service.ts

@@ -351,20 +351,24 @@ export class RotationsService {
    * 기본적으로는 모든 로테이션을 반환.
    * 만약 parameter로 month와 year가 들어오면, 해당 스코프에 맞는 레코드를 반환.
    */
-  async findAllRotation(year: number, month: number): Promise<FindAllRotationDto[]> {
-    const records = this.rotationRepository.find({
+  async findAllRotation(year?: number, month?: number): Promise<FindAllRotationDto[]> {
+    const records = await this.rotationRepository.find({
       where: {
-        year: year,
-        month: month,
+        year,
+        month,
+      },
+      relations: ['user'],
+      select: {
+        user: {
+          nickname: true,
+        },
       },
     });
 
-    const modifiedRecords = await Promise.all(
-      (await records).map(async (record) => {
-        const userRecord = await this.userService.findOneById(record.userId);
-        return { ...record, intraId: userRecord.nickname };
-      }),
-    );
+    const modifiedRecords = records.map((records) => {
+      const { user, ...other } = records;
+      return { ...other, intraId: user.nickname };
+    });
 
     return modifiedRecords;
   }