hotfix: fix additional cases and modify service logic

Author: sideseal

Diff for: src/rotation/pipe/month-validation.pipe.ts

@@ -3,10 +3,17 @@ import { BadRequestException, Injectable, PipeTransform } from '@nestjs/common';
 @Injectable()
 export class MonthValidationPipe implements PipeTransform {
   transform(value: any) {
-    const month = parseInt(value, 10);
-    if (isNaN(month) || month === null) {
+    if (value === undefined || value === null) {
       return 0;
-    } else if (month < 1 || month > 12) {
+    } else if (value.match(/^[0-9]+$/) === null) {
+      throw new BadRequestException(`Invalid month: ${value}`);
+    } else {
+      /* valid number format */
+    }
+
+    const month = parseInt(value, 10);
+
+    if (month < 1 || month > 12) {
       throw new BadRequestException(`Invalid month: ${value}`);
     } else {
       return value;

Diff for: src/rotation/pipe/year-validation.pipe.ts

@@ -3,10 +3,17 @@ import { BadRequestException, Injectable, PipeTransform } from '@nestjs/common';
 @Injectable()
 export class YearValidationPipe implements PipeTransform {
   transform(value: any) {
-    const year = parseInt(value, 10);
-    if (isNaN(year) || year === null) {
+    if (value === undefined || value === null) {
       return 0;
-    } else if (year < 2020 || year > 2100) {
+    } else if (value.match(/^[0-9]+$/) === null) {
+      throw new BadRequestException(`Invalid year: ${value}`);
+    } else {
+      /* valid number format */
+    }
+
+    const year = parseInt(value, 10);
+
+    if (year < 2020 || year > 2100) {
       throw new BadRequestException(`Invalid year: ${value}`);
     } else {
       return value;

Diff for: src/rotation/rotations.controller.ts

@@ -157,8 +157,8 @@ export class RotationsController {
   @ApiBadRequestResponse({ type: BadRequestExceptionBody })
   @ApiInternalServerErrorResponse({ type: InternalServerExceptionBody })
   findAllRotation(
-    @Query('year', new YearValidationPipe()) year: number,
-    @Query('month', new MonthValidationPipe()) month: number,
+    @Query('year', new YearValidationPipe()) year: any,
+    @Query('month', new MonthValidationPipe()) month: any,
   ): Promise<FindAllRotationDto[]> {
     return this.rotationsService.findAllRotation(year, month);
   }

Diff for: src/rotation/rotations.service.ts

@@ -354,15 +354,24 @@ export class RotationsService {
   async findAllRotation(year?: number, month?: number): Promise<FindAllRotationDto[]> {
     let records: Promise<RotationEntity[]>;
 
-    if (year && month) {
+    if (!year && !month) {
+      records = this.rotationRepository.find();
+    } else {
+      const currentDate = new Date();
+      if (!year) {
+        year = currentDate.getFullYear();
+      } else if (!month) {
+        month = currentDate.getMonth() + 1;
+      } else {
+        /* both inputs are exists */
+      }
+
       records = this.rotationRepository.find({
         where: {
           year: year,
           month: month,
         },
       });
-    } else {
-      records = this.rotationRepository.find();
     }
 
     const modifiedRecords = await Promise.all(