fix: change return type in findAllRotation and remove comment

Author: sideseal

Diff for: src/rotation/rotations.controller.ts

@@ -42,6 +42,7 @@ import {
 import { FindTodayRotationDto } from './dto/find-today-rotation.dto';
 import { FindRegistrationDto } from './dto/find-registration.dto';
 import { MonthValidationPipe } from './pipe/month-validation.pipe';
+import { FindAllRotationDto } from './dto/find-all-rotation.dto';
 
 @Controller('rotations')
 @ApiTags('rotations')
@@ -157,7 +158,7 @@ export class RotationsController {
   findAllRotation(
     @Query('year') year: number,
     @Query('month', new MonthValidationPipe()) month: number,
-  ): Promise<Partial<RotationEntity>[]> {
+  ): Promise<FindAllRotationDto[]> {
     return this.rotationsService.findAllRotation(year, month);
   }
 

Diff for: src/rotation/rotations.service.ts

@@ -21,6 +21,7 @@ import { HolidayService } from 'src/holiday/holiday.service';
 import { createRotation } from './utils/rotation';
 import { FindTodayRotationDto } from './dto/find-today-rotation.dto';
 import { FindRegistrationDto } from './dto/find-registration.dto';
+import { FindAllRotationDto } from './dto/find-all-rotation.dto';
 
 function getRotationCronTime() {
   if (process.env.NODE_ENV === 'production') {
@@ -225,19 +226,7 @@ export class RotationsService {
     }
 
     const intraIdRecord = await this.userService.findOneById(userId);
-    // const modifiedRecord = {};
-
-    // if (records.length == 0) {
-    //   modifiedRecord['year'] = year;
-    //   modifiedRecord['month'] = month;
-    //   modifiedRecord['attendLimit'] = [];
-    //   modifiedRecord['intraId'] = intraIdRecord.nickname;
-    // } else {
-    //   modifiedRecord['year'] = records[0].year;
-    //   modifiedRecord['month'] = records[0].month;
-    //   modifiedRecord['attendLimit'] = records[0].attendLimit;
-    //   modifiedRecord['intraId'] = intraIdRecord.nickname;
-    // }
+
     let modifiedRecord: FindRegistrationDto;
 
     if (records.length == 0) {
@@ -362,8 +351,8 @@ export class RotationsService {
    * 기본적으로는 모든 로테이션을 반환.
    * 만약 parameter로 month와 year가 들어오면, 해당 스코프에 맞는 레코드를 반환.
    */
-  async findAllRotation(year?: number, month?: number): Promise<Partial<RotationEntity>[]> {
-    let records: Promise<Partial<RotationEntity>[]>;
+  async findAllRotation(year?: number, month?: number): Promise<FindAllRotationDto[]> {
+    let records: Promise<RotationEntity[]>;
 
     if (year && month) {
       records = this.rotationRepository.find({