Make the query script simpler and more robust #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My motive behind this pull request is that sometime between 2021-07-01 and 2021-11-06, GitHub started to add |
generalmimon
force-pushed
the
simplify-and-make-robust
branch
3 times, most recently
from
585cbfc to
fd10912
Compare
|
@generalmimon Thanks for the PR! I'll check it out this weekend. |
Tiryoh
added
Type: Bug
* Use `--get` instead of `-X GET`, as recommended in `curl` docs ( https://curl.se/docs/manpage.html#-X, https://curl.se/docs/manpage.html#-G ) * Set the HTTP header `Accept: application/vnd.github.v3+json`, as recommended throughout the GitHub REST API docs: https://docs.github.com/en/rest/reference/actions#list-jobs-for-a-workflow-run * Make the actual command simpler and more robust (avoids potential quoting issues, does not attempt to parse JSON output or the URL with `grep` or `sed` which is inherently unreliable and error-prone, etc.), using the approach from https://github.com/hashicorp/terraform-provider-external/blob/v2.2.0/website/docs/data_source.html.md#processing-json-in-shell-scripts * Double-quote all variables according to https://www.shellcheck.net/, see https://github.com/koalaman/shellcheck/wiki/SC2086 * Add newline at end of file
generalmimon
force-pushed
the
simplify-and-make-robust
branch
from
fd10912 to
95dc4bf
Compare
Tiryoh
approved these changes
Jan 29, 2022
|
It's awesome! |
|
Thanks again for your contribution, @generalmimon. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the query script simpler and more robust
--getinstead of-X GET, as recommended incurldocs( https://curl.se/docs/manpage.html#-X,
https://curl.se/docs/manpage.html#-G )
Accept: application/vnd.github.v3+json, asrecommended throughout the GitHub REST API docs:
https://docs.github.com/en/rest/reference/actions#list-jobs-for-a-workflow-run
quoting issues, does not attempt to parse JSON output or the URL with
greporsedwhich is inherently unreliable and error-prone, etc.),using the approach from
https://github.com/hashicorp/terraform-provider-external/blob/v2.2.0/website/docs/data_source.html.md#processing-json-in-shell-scripts
see https://github.com/koalaman/shellcheck/wiki/SC2086