Merge pull request #68 from tinoest/master

Fixes for PHP 8.0 and typecase logic

Author: tinoest

TinyPortal/Controller/ArticleAdmin.php

@@ -1285,10 +1285,10 @@ public function action_settings() {{{
             $checkboxes = array('use_wysiwyg', 'use_dragdrop', 'hide_editarticle_link', 'print_articles', 'allow_links_article_comments', 'hide_article_facebook', 'hide_article_twitter', 'hide_article_reddit', 'hide_article_digg', 'hide_article_delicious', 'hide_article_stumbleupon');
             foreach($checkboxes as $v) {
                 if(TPUtil::checkboxChecked('tp_'.$v)) {
-                    $updateArray[$v] = "1";
+                    $updateArray[$v] = 1;
                 }
                 else {
-                    $updateArray[$v] = "";
+                    $updateArray[$v] = 0;
                 }
                 // remove the variable so we don't process it twice before the old logic is removed
                 unset($_POST['tp_'.$v]);

TinyPortal/Controller/BlockAdmin.php

@@ -713,10 +713,10 @@ public function action_panels() {{{
         $checkboxes = array('hidebars_admin_only', 'hidebars_profile', 'hidebars_pm', 'hidebars_memberlist', 'hidebars_search', 'hidebars_calendar');
         foreach($checkboxes as $v) {
             if(TPUtil::checkboxChecked('tp_'.$v)) {
-                $updateArray[$v] = "1";
+                $updateArray[$v] = 1;
             }
             else {
-                $updateArray[$v] = "";
+                $updateArray[$v] = 0;
             }
             // remove the variable so we don't process it twice before the old logic is removed
             unset($_POST['tp_'.$v]);

TinyPortal/Controller/PortalAdmin.php

@@ -117,10 +117,10 @@ public function update_settings() {{{
         $checkboxes = array('imageproxycheck', 'admin_showblocks', 'oldsidebar', 'disable_template_eval', 'fulltextsearch', 'hideadminmenu', 'useroundframepanels', 'showcollapse', 'blocks_edithide', 'uselangoption', 'use_groupcolor', 'showstars');
         foreach($checkboxes as $v) {
             if(TPUtil::checkboxChecked('tp_'.$v)) {
-                $updateArray[$v] = "1";
+                $updateArray[$v] = 1;
             }
             else {
-                $updateArray[$v] = "";
+                $updateArray[$v] = 0;
             }
             // remove the variable so we don't process it twice before the old logic is removed
             unset($_POST['tp_'.$v]);
@@ -219,10 +219,10 @@ public function update_frontpage() {{{
         $checkboxes     = array('allow_guestnews', 'forumposts_avatar', 'use_attachment');
         foreach($checkboxes as $v) {
             if(TPUtil::checkboxChecked('tp_'.$v)) {
-                $updateArray[$v] = "1";
+                $updateArray[$v] = 1;
             }
             else {
-                $updateArray[$v] = "";
+                $updateArray[$v] = 0;
             }
             // remove the variable so we don't process it twice before the old logic is removed
             unset($_POST['tp_'.$v]);