Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

didnt updated domain - Cloudflare #33

Closed
Excel1 opened this issue Jan 21, 2019 · 21 comments · Fixed by #94
Closed

didnt updated domain - Cloudflare #33

Excel1 opened this issue Jan 21, 2019 · 21 comments · Fixed by #94

Comments

@Excel1
Copy link

Excel1 commented Jan 21, 2019

GoDNS works correctly on subdomains like "www" or "test". But it seems to be that only subdomains got updated. Domains like "example.com" got ignored. (Only tested by using Cloudflare)

@Thor77
Copy link

Thor77 commented Jan 21, 2019

This "bug" was introduced with 0fdb8af.
Was there a reason for this @TimothyYe?

@TimothyYe
Copy link
Owner

Hi @Excel1 & @Thor77
Actually, GoDNS is only designed for updating subdomains, there is another issue also mentioned about this #32

And the existing handlers DNSPod Handler & HE Handler they both are implemented as only update subdomains to make all these handlers have the same behavior, I just updated the Cloudflare Handler yesterday.

@TimothyYe
Copy link
Owner

TimothyYe commented Jan 22, 2019

@Excel1 There is still a way to solve this problem. If you want not just subdomains are updated but also the domain itself, you can use the previously released version like https://github.com/TimothyYe/godns/releases/tag/V1.6.1

@Excel1
Copy link
Author

Excel1 commented Jan 23, 2019

@TimothyYe Maybe you can create an option in the config file to turn it on or off

@TimothyYe
Copy link
Owner

Good suggestion! I'll consider to add it, thanks!

@fabianski7
Copy link
Contributor

Is this not working for cloudflare?
The exemple.com domain is ignored and your ip is not being updated.

[GoDNS] 2019/07/24 12:27:22 GoDNS started, entering main loop...
[GoDNS] 2019/07/24 12:27:23 Creating DNS handler with provider: Cloudflare
[GoDNS] 2019/07/24 12:27:24 Current IP is: 123.123.123.123
[GoDNS] 2019/07/24 12:27:24 Checking IP for domain example.com
[GoDNS] 2019/07/24 12:27:39 Skiping record: example.com
[GoDNS] 2019/07/24 12:27:39 Going to sleep, will start next checking in 300 seconds...

I'm using version 1.8

@fabianski7
Copy link
Contributor

my config.json

{
  "provider": "Cloudflare",
  "email": "[email protected]",
  "password": "786dasdasdas8d9as798s7s8cxz8x8xx",
  "domains": [{
      "domain_name": "example.com"
    }
  ],
  "ip_url": "https://myip.biturl.top",
  "interval": 300,
  "socks5_proxy": ""
}

@TimothyYe
Copy link
Owner

Currently only supports to update subdomains.

@fabianski7
Copy link
Contributor

I understand. however Do you have any plans to add duckdns support?
The current options are very good and stable, but have a slightly high dns propagation time.

@TimothyYe
Copy link
Owner

@fabianskibr Do you mean https://www.duckdns.org?

@fabianski7
Copy link
Contributor

Yes, exactly

@TimothyYe
Copy link
Owner

Checked, it is possible to support.

@fabianski7
Copy link
Contributor

would be great

@TimothyYe
Copy link
Owner

When it is completed, I will notify you.

@fabianski7
Copy link
Contributor

ok thanks i will test

@TimothyYe
Copy link
Owner

TimothyYe commented Jul 29, 2019

@fabianskibr, GoDNS V1.9 is released to support DuckDNS, you may try it: https://github.com/TimothyYe/godns/releases/tag/V1.9

@fabianski7
Copy link
Contributor

@fabianskibr, GoDNS V1.9 is released to support DuckDNS, you may try it: https://github.com/TimothyYe/godns/releases/tag/V1.9

Seems not working for windows, godns.exe executable doesn't open
I just added my token and my subdomain (it's only numbers)

my config:

{
  "provider": "DuckDNS",
  "password": "",
  "login_token": "123123123132132",
  "domains": [
    {
      "domain_name": "www.duckdns.org",
      "sub_domains": [
        "84714641"
      ]
    }
  ],
  "ip_url": "https://icanhazip.com",
  "interval": 30,
  "socks5_proxy": "",
}

I tried too

      "domain_name": "duckdns.org",
      "sub_domains": [
        "84714641"
       ]

and

      "domain_name": "84714641.duckdns.org",
      "sub_domains": [
        ""
       ]

@fabianski7
Copy link
Contributor

It's working on linux, I just have to remove the comma at the end of this line:

"socks5_proxy": "",

I realize that it always updates the ip even if there are no changes, is that how it should work anyway?

@TimothyYe
Copy link
Owner

TimothyYe commented Jul 30, 2019

@fabianskibr README already updated, the comma is removed.
It is suggested to set the interval as 300 seconds.

And the V1.9 release is also updated, please download the latest version.
It should not always update the IP unless it is changed.

@fabianski7
Copy link
Contributor

Everything works now, great!

@TimothyYe
Copy link
Owner

@fabianskibr Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants