From 6df895d2627a4b22c2822da0bc037cd2e36ae20c Mon Sep 17 00:00:00 2001 From: Moritz Hoffmann Date: Mon, 5 Feb 2024 14:57:50 -0500 Subject: [PATCH] Remove experiments (#544) It's not used and not maintained. Signed-off-by: Moritz Hoffmann --- Cargo.toml | 1 - experiments/Cargo.toml | 12 --- experiments/benches/exchange_bench.rs | 104 -------------------------- 3 files changed, 117 deletions(-) delete mode 100644 experiments/Cargo.toml delete mode 100644 experiments/benches/exchange_bench.rs diff --git a/Cargo.toml b/Cargo.toml index e7bacb486..b36edac5e 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -6,7 +6,6 @@ members = [ "kafkaesque", "logging", "timely", - "experiments" ] [profile.release] diff --git a/experiments/Cargo.toml b/experiments/Cargo.toml deleted file mode 100644 index 6a0453f18..000000000 --- a/experiments/Cargo.toml +++ /dev/null @@ -1,12 +0,0 @@ -[package] -name = "experiments" -version = "0.1.0" -edition = "2018" - -[dependencies] -criterion = "0.3.5" -timely = { path = "../timely" } - -[[bench]] -name = "exchange_bench" -harness = false diff --git a/experiments/benches/exchange_bench.rs b/experiments/benches/exchange_bench.rs deleted file mode 100644 index cf9337ca4..000000000 --- a/experiments/benches/exchange_bench.rs +++ /dev/null @@ -1,104 +0,0 @@ -extern crate timely; - -use std::fmt::{Display, Formatter}; -use std::time::{Duration, Instant}; - -use criterion::black_box; -use criterion::*; - -use timely::dataflow::operators::{Exchange, Input, Probe}; -use timely::dataflow::InputHandle; -use timely::{CommunicationConfig, Config, WorkerConfig}; - -#[derive(Clone)] -struct ExperimentConfig { - threads: usize, - batch: u64, -} - -impl Display for ExperimentConfig { - fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result { - write!(f, "threads={:2},batch={:5}", self.threads, self.batch) - } -} - -fn bench(c: &mut Criterion) { - let mut group = c.benchmark_group("exchange"); - for threads in [1, 2, 4, 8, 16] { - for shift in [0, 4, 8, 14] { - let params = ExperimentConfig { - threads, - batch: 1u64 << shift, - }; - group.bench_with_input( - BenchmarkId::new("Default", params.clone()), - ¶ms, - move |b, params| { - b.iter_custom(|iters| { - let config = Config::process(params.threads); - black_box(experiment_exchange( - config, - params.batch, - iters, - )) - }) - }, - ); - group.bench_with_input( - BenchmarkId::new("DefaultZero", params.clone()), - ¶ms, - move |b, params| { - b.iter_custom(|iters| { - let config = Config { - communication: CommunicationConfig::ProcessBinary(params.threads), - worker: WorkerConfig::default(), - }; - black_box(experiment_exchange( - config, - params.batch, - iters, - )) - }) - }, - ); - } - } -} - -fn experiment_exchange( - config: Config, - batch: u64, - rounds: u64, -) -> Duration { - timely::execute(config, move |worker| { - let mut input = InputHandle::new(); - let probe = worker.dataflow(|scope| scope.input_from(&mut input).exchange(|x| *x).probe()); - - let mut time = 0; - let timer = Instant::now(); - - let buffer = (0..batch).collect(); - let mut copy = Vec::new(); - - for _round in 0..rounds { - copy.clone_from(&buffer); - input.send_batch(&mut copy); - copy.clear(); - time += 1; - input.advance_to(time); - while probe.less_than(input.time()) { - worker.step(); - } - } - timer.elapsed() - }) - .unwrap() - .join() - .into_iter() - .next() - .unwrap() - .unwrap() -} - -criterion_group!(benches, bench); -criterion_main!(benches);