Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

!now command doesn't use combo or miss count #160

Open
jonstvns opened this issue Feb 12, 2018 · 3 comments
Open

!now command doesn't use combo or miss count #160

jonstvns opened this issue Feb 12, 2018 · 3 comments

Comments

@jonstvns
Copy link

The !now command doesn't appear to use your last play's combo or miss count, so it returns the wrong pp value. Is this something that is able to be fixed/improved?

The last play using !now:
image

The same play using !acc with all of the parameters filled in:
image

@Tillerino
Copy link
Owner

The idea of the !now command is not to see how much your pp your last play gave, but to see what had happened if you got a FC on the last play (includes no misses). It's more of a how-much-pp-did-I-just-miss-out-on-command.

@jonstvns
Copy link
Author

I guess that makes sense.

Would it be much trouble to also have a command that includes combo and misses from the last play?

@omkelderman
Copy link
Collaborator

that would be super easy to make, if there is demand for it, sure.

@Tillerino suggestion on command naming? some optional argument kinda thing to !now or something completely different, like !last or something, idk?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants