Groups API + Tests + Example v2 #69
Conversation
abigalekim
changed the base branch from
main
to
abigalekim/sc-43477/groups-api-example
abigalekim
changed the base branch from
abigalekim/sc-43477/groups-api-example
to
main
abigalekim
force-pushed
the
pd/abigalekim/sc-43477/groups-api-example
branch
from
577ca5b to
8d8818d
Compare
tiledb/api/src/group/mod.rs
Outdated
| } | ||
|
|
||
| pub fn consolidate_metadata<S>( | ||
| &self, |
There was a problem hiding this comment.
This C API doc doesn't mention anything about the group open mode but this sure sounds like a mutating function call...
Anyway, as I've been mulling over the whole "some methods are &mut self and some aren't" thing, it's kind of occurred to me that &mut self to represent a write mode method doesn't really work because the API allows you to just get another handle, and then you have ownership of that second handle and can call whatever you want anyway. And this can go in the direction of "just let the C API give back the error and don't worry about it" or in the direction of "embed the permissions to call certain APIs in the type system". If we had infinite time I'd want the latter but let's move ahead with the former for now.
abigalekim
force-pushed
the
pd/abigalekim/sc-43477/groups-api-example
branch
from
c04d7f3 to
26a6d66
Compare
|
Added a story for consolidate and vacuum tests: https://app.shortcut.com/tiledb-inc/story/46102/write-tests-for-group-consolidate-and-group-vacuum |
| Float64Value(Vec<f64>), | ||
| //StringAsciiValue(CString), | ||
| //BooleanValue(bool), | ||
| // maybe blobs? |
There was a problem hiding this comment.
Lets remove commented out code here.
| .capi_return(unsafe { | ||
| ffi::tiledb_group_is_open(c_context, raw_group.ffi, &mut c_open) | ||
| }) | ||
| .expect("TileDB internal error when checking for open group."); |
There was a problem hiding this comment.
expect isn't appropriate here since we can return Result
also I think you can remove this if you want, your comment yesterday (earlier this week? something) in Drop convinced me that you did it correctly the first time
No description provided.