Move arrow sub-crate into api crate feature #58
Merged
+256
−283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davisp
approved these changes
Apr 16, 2024
| @@ -520,7 +520,10 @@ impl<'ctx> Factory<'ctx> for AttributeData { | |||
| } | |||
| } | |||
|
|
|||
| #[cfg(feature = "proptest-strategies")] | |||
| #[cfg(feature = "arrow")] | |||
There was a problem hiding this comment.
Should we not add the same any(test, ...) for arrow?
There was a problem hiding this comment.
I'd say the difference is that the proptest strategies we need to do the testing of the other stuff, whereas arrow is just a thing we want to test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We may to do some heavier work with arrow integrations, such as including implementing some of our traits for arrow structures. Rust forbids implementing a trait on a struct unless the trait is defined in the current crate, or the struct is defined in the current crate. Hence we should move our arrow work into the api crate and hide it behind a feature.
Of note here is that the arrow tests all used our proptest strategies. Cargo does not allow features to specify their own dev dependencies, so instead we change all the strategy modules from
#[cfg(feature = "proptest-strategies")]to
#[cfg(any(test, feature = "proptest-strategies"))]so that the strategies can be used whether testing or specifying tiledb as a dependency with the proptest-strategies feature.