Implement conversion between TIleDB Schema and Arrow Schema #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #43826: Invertible function to convert between TileDB Schema and Arrow Schema. |
rroelke
commented
Mar 27, 2024
| use tiledb::{error::Error as TileDBError, fn_typed, Result as TileDBResult}; | ||
|
|
||
| use crate::datatype::{arrow_type_physical, tiledb_type_physical}; | ||
|
|
||
| /// Encapsulates TileDB filter data for storage in Arrow Field metadata | ||
| #[derive(Deserialize, Serialize)] |
There was a problem hiding this comment.
I moved this to its own module arrow/src/filter.rs.
| use proptest::prelude::*; | ||
|
|
||
| #[test] | ||
| fn test_tiledb_arrow_tiledb() { |
There was a problem hiding this comment.
In the attribute module we also have test_arrow_tiledb_arrow. For attribute the tiledb metadata is optional, but for dimension it is required, so it's much harder to write that test.
davisp
approved these changes
Mar 27, 2024
Comment on lines
+94
to
+95
| DimensionKey::Index(idx) => Ok(idx < self.ndim()), | ||
| DimensionKey::Name(name) => { |
There was a problem hiding this comment.
Oooh! Nice, this is a pattern to remember to avoid having to have multiple functions in a lot of the places where we allow lookups by index or name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements functions to convert between TileDB schema and Arrow schema.
As in #28, we use a serializable objects to store details about the TileDB schema and/or dimension which do not have a natural field in the Arrow Schema.
There aren't any notable new designs here, just lots of details which were missing including several
PartialEqimplementations, some fields fromDebug, someffimethods which were not implemented yet, and some updates to the proptest strategies. Among the missing methods were the Schema's filter list setters and getters - these depend on the Domain to generate sound values, so I was unable to add them to proptest as we have discussed as length in Slack.Resolves sc#43826.