feat: [sc-44563] Wrap Encryption related APIs #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rroelke
force-pushed
the
rr/sc-44563-encryption-api
branch
from
6c15987 to
05688cc
Compare
davisp
approved these changes
Sep 27, 2024
| #[derive(Clone, Debug)] | ||
| pub enum CommonOption { | ||
| /// Sets an AES256GCM encryption key. | ||
| Aes256GcmEncryptionKey(Vec<u8>), |
There was a problem hiding this comment.
I wonder if this shouldn't be defined as something like:
pub enum CommonOption {
Encryption(array::Encryption, Option<String>)
}This is only a vague "might be better, might not" suggestion. So feel free to do what you want with it.
There was a problem hiding this comment.
My thinking here (and the way I am following up in the tables repo so far) is that other future encryption types (if there will ever be any) might have more or different arguments. So for now I'm just going with this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story details: https://app.shortcut.com/tiledb-inc/story/44563
This pull request enables interactions with encrypted arrays, and adds a unit test demonstrating creating an encrypted array and opening it, following along the C API example.
The encryption key is set on the tiledb Config object. As this seems like a common use case, we add the convenience API
CommonOptionwhich makes configuration settings much more discoverable than writing the string in documentation somewhere.