Proptest for checking correctness of a single sparse write #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davisp
approved these changes
May 28, 2024
| self.capi_call(|ctx| unsafe { | ||
| ffi::tiledb_array_schema_get_allows_dups( |
| let schema_version = s.version().unwrap(); | ||
|
|
||
| // it's a little awkward to use a constant here but this does | ||
| // not appear to be tied to the library version |
There was a problem hiding this comment.
Correct. The schema version is actually the underlying data format which is incremented anytime we change how something is stored on disk. You can find the mapping of storage format versions to library versions here:
| /// Test what the default values filled in for `None` with schema data are. | ||
| /// Mostly because if we write code which does need the default, we're expecting | ||
| /// to match core and need to be notified if something changes or we did something | ||
| /// wrong. |
…ry-proptest-sparse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the follow-up to #98 , extending the proptest to also work correctly for sparse writes.
Things this pull request had to deal with:
There are a few notable tools used to accomplish these goals.
As we've been building out the API we've had more and more reasons to separate handling of floating-point types from integral types for the various enums that can hold both. This pull request encounters yet another, and so we add the
crate::datatype::Integraltrait as a helper for writing generic code over u8, u16, u32, etc.Another tool added here is an analog of
Iterator::mapfor the query callback adapters. We addmap_intermediate,map_final, andmapfunctions for transforming the result of a callback into something else.