Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release using macos-13 #5400

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Release using macos-13 #5400

merged 2 commits into from
Dec 9, 2024

Conversation

dudoslav
Copy link
Collaborator

@dudoslav dudoslav commented Dec 6, 2024

Use macos-13 for x86_64 macos release job, since macos-12 is deprecated


TYPE: NO_HISTORY
DESC: Use macos-13 for macos x86_64 release

@dudoslav dudoslav self-assigned this Dec 6, 2024
@jdblischak
Copy link
Contributor

xref: This is the reason the no release binaries have been uploaded for 2.27.0-rc4. The osx-64 job was automatically canceled because it used the recently deprecated macos-12.

Frustratingly, as I've observed in other repos, even though we include cancelled() in the conditions for the job to open an Issue, no Issue was opened (or rather, no comment was added to the existing open Issue, #5389). Not sure if cancelled() just doesn't work, or if that only applies to when a user cancels the job manually (as opposed to this case of a deprecated image runner)

https://github.com/TileDB-Inc/TileDB/blob/2.27.0-rc4/.github/workflows/release.yml#L233

if: (failure() || cancelled()) && github.event_name == 'push'

@dudoslav dudoslav changed the title Draft: Release using macos-13 Release using macos-13 Dec 9, 2024
@dudoslav dudoslav requested a review from ihnorton December 9, 2024 10:04
@teo-tsirpanis
Copy link
Member

Did the issue that led to the adoption of macos-12 get fixed, namely the wrong artifact names?

@dudoslav
Copy link
Collaborator Author

dudoslav commented Dec 9, 2024

Did the issue that led to the adoption of macos-12 get fixed, namely the wrong artifact names?

This run shows the produced artifacts:
https://github.com/dudoslav/TileDB/actions/runs/12199483608

Unzipping the resulting artifact:

[dudoslav@taco Downloads]$ unzip release\ \(1\).zip
Archive:  release (1).zip
  inflating: tiledb-linux-x86_64-macosx-13-edad604.tar.gz.sha256
  inflating: tiledb-linux-x86_64-macosx-13-edad604.tar.gz
  inflating: tiledb-linux-x86_64-noavx2-macosx-13-edad604.tar.gz.sha256
  inflating: tiledb-linux-x86_64-noavx2-macosx-13-edad604.tar.gz
  inflating: tiledb-macos-arm64-macosx-13-edad604.tar.gz.sha256
  inflating: tiledb-macos-arm64-macosx-13-edad604.tar.gz
  inflating: tiledb-macos-x86_64-macosx-13-edad604.tar.gz.sha256
  inflating: tiledb-macos-x86_64-macosx-13-edad604.tar.gz
  inflating: tiledb-source-macosx-13-edad604.tar.gz.sha256
  inflating: tiledb-source-macosx-13-edad604.tar.gz
  inflating: tiledb-windows-x86_64-macosx-13-edad604.zip.sha256
  inflating: tiledb-windows-x86_64-macosx-13-edad604.zip

We fixed this issue by specifying the release os to macos-12 that is x86_64 platform, and macos-13 should be the same:
#5384

@ihnorton ihnorton merged commit 5784276 into TileDB-Inc:dev Dec 9, 2024
60 checks passed
Copy link
Member

@teo-tsirpanis teo-tsirpanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ihnorton
Copy link
Member

ihnorton commented Dec 9, 2024

/backport to release-2.27

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Copy link
Contributor

github-actions bot commented Dec 9, 2024

@ihnorton an error occurred while backporting to release-2.27, please check the run log for details!

The process '/usr/bin/git' failed with exit code 1

dudoslav added a commit that referenced this pull request Dec 9, 2024
Use `macos-13` for x86_64 macos release job, since `macos-12` is
deprecated

---
TYPE: NO_HISTORY
DESC: Use `macos-13` for macos x86_64 release

Co-authored-by: Dušan Baran <[email protected]>
ihnorton pushed a commit that referenced this pull request Dec 9, 2024
Use `macos-13` for x86_64 macos release job, since `macos-12` is
deprecated

---
TYPE: NO_HISTORY
DESC: Use `macos-13` for macos x86_64 release

Co-authored-by: Dušan Baran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants