-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C.41 compliance: Azure factory constructor. #5392
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(some of the comments apply to the PRs for GCS and HDFS, I will review them more thorougly after reviewing this PR finishes)
I am not a fan of the ***_within_VFS
mechanism and cannot understand why it was introduced. My attempts to find more context in source code documentation, the review comments of #4360 or the Shortcut story were unfruitful. We can't easily remove it for S3 because test code has a dependency on it, but we shouldn't do the same for the other VFSes.
* @note The member variables' default declarations have not yet been moved | ||
* from the Config declaration into this struct. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After we do that it might be a good idea to restore the default constructor.
Note that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work with removing Status
, thanks!
I left some comments and still believe that Azure_within_VFS
should be removed before I approve.
cc: @teo-tsirpanis After discussion with @ihnorton offline, we've decided to stick with the current design. This entails use of |
We could do these as part of this larger refactor, where there will be more context for understanding their necessity, but I don't mind either way. |
Remove
Azure::init
in favor of a C.41-compliant factory constructor. TheAzure::azure_params_
member variable is no longer optional and is fully-initialized at construction time.[sc-60071]
TYPE: IMPROVEMENT
DESC: C.41 constructor:
Azure
.