Add classes for Task and SharedTask in threadpool #5391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ypatia
force-pushed
the
yt/sc-59606/threadpool_with_tasks
branch
from
411e836 to
e3aff67
Compare
ypatia
force-pushed
the
yt/sc-59606/threadpool_with_tasks
branch
from
0b11b03 to
2d0a155
Compare
ypatia
force-pushed
the
yt/sc-59606/threadpool_with_tasks
branch
3 times, most recently
from
49dfadf to
7c9acb3
Compare
|
Passes CI, the MANYLINUX failure is a known issue. |
ypatia
force-pushed
the
yt/sc-59606/threadpool_with_tasks
branch
from
7c9acb3 to
bdd4b48
Compare
Shelnutt2
reviewed
Dec 2, 2024
| @@ -432,7 +432,7 @@ Status DenseReader::dense_read() { | |||
| // prevent using too much memory when the budget is small and doesn't allow | |||
| // to process more than one batch at a time. | |||
| if (wait_compute_task_before_read && compute_task.valid()) { | |||
| throw_if_not_ok(resources_.compute_tp().wait(compute_task)); | |||
| throw_if_not_ok(resources_.compute_tp().wait(&compute_task)); | |||
There was a problem hiding this comment.
Is the plan to replace all calls to tp.wait(task) with task.wait()?
There was a problem hiding this comment.
yes, I can do it already if you think it should be in this PR, or in the following work as I was planning.
There was a problem hiding this comment.
Hmm, on the one hand I prefer the existing APIs because the action primarily happens on the thread pool instead of the task, but on the other hand there is already a wait() method on std::future that we must be careful not to call because of deadlocks. 🤔
There was a problem hiding this comment.
Right, and also having to pass around a reference to the threadpool object everywhere is quite cumbersome.
ypatia
force-pushed
the
yt/sc-59606/threadpool_with_tasks
branch
from
e30927b to
c92a83c
Compare
Shelnutt2
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
ThreadPool::Taskis a typedef tostd:: future<Status>. This PR:waitfor our async processes to go through our ThreadPool's wait method. In that way, we never use astd::future'swaitmethod directly and we avoid possible deadlocks because only the ThreadPool'swaitwill yield.SharedTask, that is encapsulatingstd::shared_futurewhich allows multiple threads to wait on an async operation result to become available. This is needed for the upcoming work on parallelizing IO and compute operations in the codebase even further.This is heavily influenced from similar work by @Shelnutt2.
TYPE: IMPROVEMENT
DESC: Add classes for Task and SharedTask in threadpool