Skip to content

Commit 39ed082

Browse files
skinny85TikiTDO
authored andcommitted
chore(iot): rename FirehoseStreamProps to FirehoseStreamActionProps (aws#17495)
An action item from aws#17466 (review). ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent bdc1587 commit 39ed082

11 files changed

+4
-6
lines changed

Diff for: packages/@aws-cdk/aws-iot-actions/README.md

+2-4
Original file line numberDiff line numberDiff line change
@@ -136,9 +136,7 @@ import * as s3 from '@aws-cdk/aws-s3';
136136
import * as firehose from '@aws-cdk/aws-kinesisfirehose';
137137
import * as destinations from '@aws-cdk/aws-kinesisfirehose-destinations';
138138

139-
const bucket = new s3.Bucket(this, 'MyBucket', {
140-
removalPolicy: cdk.RemovalPolicy.DESTROY,
141-
});
139+
const bucket = new s3.Bucket(this, 'MyBucket');
142140
const stream = new firehose.DeliveryStream(this, 'MyStream', {
143141
destinations: [new destinations.S3Bucket(bucket)],
144142
});
@@ -149,7 +147,7 @@ const topicRule = new iot.TopicRule(this, 'TopicRule', {
149147
new actions.FirehoseStreamAction(stream, {
150148
batchMode: true,
151149
recordSeparator: actions.FirehoseStreamRecordSeparator.NEWLINE,
152-
})
150+
}),
153151
],
154152
});
155153
```

Diff for: packages/@aws-cdk/aws-iot-actions/lib/firehose-stream-action.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ export enum FirehoseStreamRecordSeparator {
3232
/**
3333
* Configuration properties of an action for the Kinesis Data Firehose stream.
3434
*/
35-
export interface FirehoseStreamProps extends CommonActionProps {
35+
export interface FirehoseStreamActionProps extends CommonActionProps {
3636
/**
3737
* Whether to deliver the Kinesis Data Firehose stream as a batch by using `PutRecordBatch`.
3838
* When batchMode is true and the rule's SQL statement evaluates to an Array, each Array
@@ -64,7 +64,7 @@ export class FirehoseStreamAction implements iot.IAction {
6464
* @param stream The Kinesis Data Firehose stream to which to put records.
6565
* @param props Optional properties to not use default
6666
*/
67-
constructor(private readonly stream: firehose.IDeliveryStream, props: FirehoseStreamProps = {}) {
67+
constructor(private readonly stream: firehose.IDeliveryStream, props: FirehoseStreamActionProps = {}) {
6868
this.batchMode = props.batchMode;
6969
this.recordSeparator = props.recordSeparator;
7070
this.role = props.role;

0 commit comments

Comments
 (0)