Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subscribe to "run" instead of checking "--watch" #3

Closed
Strate opened this issue Mar 11, 2016 · 2 comments
Closed

Subscribe to "run" instead of checking "--watch" #3

Strate opened this issue Mar 11, 2016 · 2 comments

Comments

@Strate
Copy link

Strate commented Mar 11, 2016

The run method of the Compiler is used to start a compilation. This is not called in watch mode.
https://webpack.github.io/docs/plugins.html

Checking for process.argv.indexof("--watch") is not good. Because there is an alias -w and watch can be set in config. More proper way to check that is it non-watching mode is subscribing to run event.
@seansfkelley seansfkelley mentioned this issue Apr 28, 2016
Closed
@TiddoLangerak
Copy link
Owner

Long overdue, but closed via #4

@TiddoLangerak
Copy link
Owner

And published with 1.0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Strate @TiddoLangerak