Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate pytest requirements in setup.py #201

Open
ruiqianyu opened this issue Nov 10, 2022 · 1 comment
Open

Duplicate pytest requirements in setup.py #201

ruiqianyu opened this issue Nov 10, 2022 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@ruiqianyu
Copy link

pytest is required twice in setup.py with different versions.
https://github.com/Thriftpy/thriftpy2/blob/master/setup.py#L36
https://github.com/Thriftpy/thriftpy2/blob/master/setup.py#L39

Seems to be the result of a recent branch merge 21b27cd#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7R39.

Remove "pytest>=2.8",?
@ethe
Copy link
Member

ethe commented Nov 11, 2022

Thanks, I will fix it later.

@aisk aisk added bug Something isn't working good first issue Good for newcomers labels Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aisk @ruiqianyu @ethe