Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with topic and consumer group names in test suite #226

Open
breml opened this issue Mar 10, 2021 · 1 comment · May be fixed by #444
Open

Issue with topic and consumer group names in test suite #226

breml opened this issue Mar 10, 2021 · 1 comment · May be fixed by #444
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed S small issue

Comments

@breml
Copy link
Contributor

breml commented Mar 10, 2021

For an implementation of #126 (PostgreSQL driver with SKIP LOCKED), I create a SQL table for each consumer group containing the offsets ready to be consumed. The name for these tables is build by concatenating some prefix, the name of the topic and the name of the consumer group. In some of the test cases in the test suite, UUID are used for both, the topic and the consumer group. Each UUID has a length of 36 characters. Concatenating an UUID for the topic and the consumer group already exceeds the maximum table name length of 63 characters supported by PostgreSQL.

Would it be possible to use a smaller ID for the topic and consumer group names used in the Watermill test suite?
@roblaszczak
Copy link
Member

Hello, I think that the solution may be using https://github.com/oklog/ulid instead of UUID. I think that it would be perfect to be able to configure it and keep the default behavior for all other tests. IMO it could be configured via test features: https://github.com/ThreeDotsLabs/watermill/blob/master/pubsub/tests/test_pubsub.go#L99

@roblaszczak roblaszczak added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed S small issue labels Apr 4, 2021
@HolyKingCrusader HolyKingCrusader linked a pull request May 27, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed S small issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds feature to use ULID in tests HolyKingCrusader/watermill
2 participants
@roblaszczak @breml