Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider evmap for use in storage #22

Open
Thomasdezeeuw opened this issue Oct 22, 2020 · 0 comments
Open

Consider evmap for use in storage #22

Thomasdezeeuw opened this issue Oct 22, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@Thomasdezeeuw
Copy link
Owner

Currently we use a simple HashMap for storing the uncommitted/stored/removed blobs. However this requires a RPC with the storage actor on each request. Using evmap this could be removed.

Related code:

stored/src/storage/mod.rs

Lines 255 to 266 in c7b3416

/// All blobs currently in [`Index`] and [`Data`].
///
/// # Safety
///
/// `blobs` must be declared before `data` because it must be dropped before
/// `data`.
// TODO: use different hashing algorithm.
blobs: HashMap<Key, (EntryIndex, BlobEntry), FxBuildHasher>,
/// Uncommitted blobs.
///
/// The `usize` is the number of [`StoreBlob`]s adding the blob.
uncommitted: HashMap<Key, (usize, UncommittedBlob), FxBuildHasher>,

@Thomasdezeeuw Thomasdezeeuw added the enhancement New feature or request label Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant