-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FullScreen issues #1895
Comments
I've deleted the video links because they where pointing to an internal server. |
I believe you have to add some styling for it to appear full screen after looking at this |
@chrissnape @giambafiume- I will take a look at this code and provide a solution for your problem ASAP. |
@chrissnape and @IbrahimSulai thank you so much for your help. |
I have the same problem. Im using react-native-router-flux, when I show a video without navigating through the router fullscreen works. Pause is broken for me too. |
@chrissnape @giambafiume @hokasan - Found the root cause for this issue. Will confirm and test thoroughly and raise separate PR for the same. |
I really appreciate your help. Thank you very much. |
@chrissnape @JerakRus @benoitdion @jsunwoo Please review the PR. |
Not working full screen on Samsung |
Is that problem solved? Any workaround here ? |
@349989153 not yet. To have something similar to a full screen mode, I've used a screen only for the video component and I've set the style of the component to 100% width. In this way, putting the device in landscape the video takes all the space available. Hope that this helps |
@giambafiume Do you mean that once you click the 'expand' button on that video controls, it just jumps to a screen that renders only The question is, how do you keep the playing time of small video and full screen video consistent ? |
No no, I'm sorry. the video component has its own screen. I don't have the expand button. The video is always in full size. |
Thank you for your help anyway ^_^ |
@IbrahimSulai I updated react-native-video to However, the problem that @giambafiume described is still exist, any idea of that bug? The existing problem I'm talking about is not really full screen, like screenshot shows, and controls is not visible in fullscreen mode in android. |
@IbrahimSulai Ok, I started to get to know that what you trying to do to support full screen, is by changing the video container's position to absolute, and changing activity's orientation to SCREEN_ORIENTATION_LANDSCAPE. However, this solution won't work if we put our |
Hi all, |
Hello @giambafiume Do you know what I am doing wrong? I have configurated the component but I am not able to see full-screen button
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. If you are having a similar problem, please open a new issue and reference this one instead of commenting on a stale or closed issue. |
Bug
I've installed the latest version of react-native-video. I'm using Android Exoplayer, when I click on the full screen button it works in a strange way:
Platform
ANDROID EXOPLAYER
Which player are you experiencing the problem on:
Environment info
System:
OS: Windows 10 10.0.17763
CPU: (8) x64 Intel(R) Core(TM) i7-8565U CPU @ 1.80GHz
Memory: 19.79 GB / 31.81 GB
Binaries:
Node: 13.7.0 - C:\Program Files\nodejs\node.EXE
Yarn: 1.21.1 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
npm: 6.13.6 - C:\Program Files\nodejs\npm.CMD
SDKs:
Android SDK:
API Levels: 28, 29
Build Tools: 28.0.3, 29.0.2
System Images: android-28 | Google APIs Intel x86 Atom, android-28 | Google Play Intel x86 Atom, android-29 | Google APIs Intel x86 Atom, android-29 | Google Play Intel x86 Atom
IDEs:
Android Studio: Version 3.5.0.0 AI-191.8026.42.35.6010548
npmPackages:
react: 16.9.0 => 16.9.0
react-native: 0.61.5 => 0.61.5
Library version: 5.1.0-alpha2
Reproducible sample code
import React, { Component } from 'react'
import { Text, View, StyleSheet, ScrollView, Button } from 'react-native'
import Icon from 'react-native-vector-icons/FontAwesome';
import Video from 'react-native-video'
class Test extends Component {
static navigationOptions= {
tabBarIcon: ({tintColor, focused}) =>(
)
}
state = {
uri: {
video1: "",
video2: "",
video3: "",
video4: "https://irtdashreference-i.akamaihd.net/dash/live/901161/bfs/manifestARD.mpd"
},
selected: "https://irtdashreference-i.akamaihd.net/dash/live/901161/bfs/manifestARD.mpd"
}
export default Test
const styles = StyleSheet.create({
backgroundVideo: {
position: 'absolute',
top: 0,
left: 0,
bottom: 0,
right: 0,
},
videoContainer: {
marginLeft:'auto',
marginRight: 'auto',
width: 360,
height: 360 * 9 / 16,
padding: 15,
marginTop: 15,
marginBottom: 15
},
buttonsContainer: {
flexDirection: "row",
justifyContent: "space-between",
marginHorizontal: "20%"
},
buttonText: {
fontSize: 10,
textAlign: "center"
}
});
The text was updated successfully, but these errors were encountered: