Feature request: True FullScreen mode for Android with ExoPlayer

[ionut-movila]

Current behavior

The lib. does not support a full screen mode for Android at this moment. Only disabling status bar and buttons bar, with method ReactExoplayerView.setFullscreen but that is far from what a full functional full screen.

Expected behavior

Full screen mode should work in a similar way with what we have on iOS. The Video element should be re-parented to a new native view that will cover existing app content, like a full screen modal. This should also include all common controls: video scrubbing, volume controls, change aspect ratio + exit full screen.

This should work for Android ExoPlayer together with or without option useTextureView.

A good starting point I have found is this answer https://stackoverflow.com/a/48511657.
I say approach no. 1 would work ok, even if it has some compromises for Android < 6 (API 23).
And also using SimpleExoPlayerView (or new PlayerView) for a full screen transition I guess is a good option.

Not to say that we really do need this feature in our app, but I would like to hear other opinions, and why not volunteers to implement it.

[cobarx]

I'm not sure what we get by re-parenting the video. On iOS, that code is super buggy and doesn't work about half the time. Imo, it's a lot easier to work with to just set the video to have the same bounds as the device and call it a day.

The biggest obstacle is that we don't have a set of controls with all the features you're mentioning. The ExoPlayer sample controls are super basic and don't look good imo.

I have built several iterations of controls as React Native components that I will eventually be able to open source. I'd be curious of your thoughts on whether we should be aiming for native controls or a React Native component is sufficient. If we do the latter, should we also make them available on iOS?

[xstable]

You might have a look at my repo.
I fork and upgraded react-native-video-player so that it now support react-native-video 4.4.0. Feel free to give it a try.

Because here, @IbrahimSulai is working on a build-in Fullscreen functionality, you can take my solution as temporary workaround

[IbrahimSulai]

Opened a PR (#1730) for full-screen support in Android Exoplayer.

[petrosmm]

@ionut-movila I would just like to add the use of PlayerView, is how I was able to get video supported from android 4.4 and up in my native android application. If you guys added this feature, it would add 4.4 compatibility for sure.

[huynextlevel]

Hi @IbrahimSulai,
I also added fullscreen={true} for android exoplayer, but It's still not working as expected (Don't see full screen in the control bar)