Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply NewChannelAns before computing 1.1 MIC #795

Closed
rvolosatovs opened this issue Jun 5, 2019 · 0 comments
Closed

Apply NewChannelAns before computing 1.1 MIC #795

rvolosatovs opened this issue Jun 5, 2019 · 0 comments
Assignees
@rvolosatovs
Labels
bug Something isn't working c/network server This is related to the Network Server in progress We're working on it
Milestone
July 2019

Comments

@rvolosatovs
Copy link
Contributor

Summary

NS shall apply NewChannelAns before computing 1.1 MIC

Why do we need this?

If NewChannelReq was sent to the device and processed successfully, the channels used by device might have been modified and hence, if a successful NewChannelAns is received in the uplink, it shall be applied before the device channel index is determined, which, in turn is used for the MIC computation in 1.1

What is already there? What do you see now?

Not this

What is missing? What do you want to see?

This

How do you propose to implement this?

Decode the MAC buffer in matchDevice and apply the NewChannelAns

Can you do this yourself and submit a Pull Request?

yes
@rvolosatovs rvolosatovs added bug Something isn't working c/network server This is related to the Network Server in progress We're working on it labels Jun 5, 2019
@rvolosatovs rvolosatovs added this to the June 2019 milestone Jun 5, 2019
@rvolosatovs rvolosatovs self-assigned this Jun 5, 2019
@rvolosatovs rvolosatovs mentioned this issue Jun 27, 2019
Merged
@johanstokking johanstokking modified the milestones: June 2019, July 2019 Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rvolosatovs rvolosatovs

Labels
bug Something isn't working c/network server This is related to the Network Server in progress We're working on it
Projects
None yet
Milestone
July 2019
Development

No branches or pull requests
2 participants
@rvolosatovs @johanstokking