-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove generated message populators from pkg/ttnpb #342
Comments
Populators are fully deterministic. |
@htdvisser is this important enough to leave it scheduled for Q2? |
We're slowly starting the big refactoring of I don't really enjoy doing these kind of chores, so I'd rather just get it over with than keep pushing it forward. |
Pull request #4450 removed all unused populators, so now it's time to remove all usage of the remaining ones, and remove those too. From what I can see, we still use populators in these places:
|
@KrishnaIyer for removing populators from @adriansmares the stuff in |
Summary:
The generated message populators in
pkg/ttnpb
cause more problems than they solve. In my experience they're only causing flaky tests because of failed validations and non-deterministic code coverage because of randomly taken branches.What do you see now?
What do you want to see instead?
The end goal is that our tests become deterministic, so ideally I'd want to see (handwritten or rule-aware) populators that have correct and deterministic output for a PRNG with the same seed.
How do you propose to implement this?
What can you do yourself and what do you need help with?
I think it's best if @rvolosatovs looked into this, because
protoc
andttnpb
is his domain. Let me know if you need any help.The text was updated successfully, but these errors were encountered: