fix: Replace strncat with strlcat for robustness (#1677)

Skyaero42 · web-flow · commit 9e4b82f32179 · 2025-10-15T22:44:38.000+02:00
diff --git a/Generals/Code/GameEngine/Source/Common/Recorder.cpp b/Generals/Code/GameEngine/Source/Common/Recorder.cpp
@@ -289,7 +289,7 @@ void RecorderClass::cleanUpReplayFile( void )
 	{
 		char fname[_MAX_PATH+1];
 		strlcpy(fname, TheGlobalData->m_baseStatsDir.str(), ARRAY_SIZE(fname));
-		strncat(fname, m_fileName.str(), _MAX_PATH - strlen(fname));
+		strlcat(fname, m_fileName.str(), ARRAY_SIZE(fname));
 		DEBUG_LOG(("Saving replay to %s", fname));
 		AsciiString oldFname;
 		oldFname.format("%s%s", getReplayDir().str(), m_fileName.str());
diff --git a/GeneralsMD/Code/GameEngine/Source/Common/Recorder.cpp b/GeneralsMD/Code/GameEngine/Source/Common/Recorder.cpp
@@ -289,7 +289,7 @@ void RecorderClass::cleanUpReplayFile( void )
 	{
 		char fname[_MAX_PATH+1];
 		strlcpy(fname, TheGlobalData->m_baseStatsDir.str(), ARRAY_SIZE(fname));
-		strncat(fname, m_fileName.str(), _MAX_PATH - strlen(fname));
+		strlcat(fname, m_fileName.str(), ARRAY_SIZE(fname));
 		DEBUG_LOG(("Saving replay to %s", fname));
 		AsciiString oldFname;
 		oldFname.format("%s%s", getReplayDir().str(), m_fileName.str());

Original file line number	Diff line number	Diff line change
`@@ -289,7 +289,7 @@ void RecorderClass::cleanUpReplayFile( void )`
`289`	`289`	`{`
`290`	`290`	`char fname[_MAX_PATH+1];`
`291`	`291`	`strlcpy(fname, TheGlobalData->m_baseStatsDir.str(), ARRAY_SIZE(fname));`
`292`		`- strncat(fname, m_fileName.str(), _MAX_PATH - strlen(fname));`
	`292`	`+ strlcat(fname, m_fileName.str(), ARRAY_SIZE(fname));`
`293`	`293`	`DEBUG_LOG(("Saving replay to %s", fname));`
`294`	`294`	`AsciiString oldFname;`
`295`	`295`	`oldFname.format("%s%s", getReplayDir().str(), m_fileName.str());`