Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PP-1914] Remove collection facet from feed. #2182

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dbernstein
Copy link
Contributor

@dbernstein dbernstein commented Nov 21, 2024

Description

This update removes the Collection Facet and all related artifacts from the code base.

Motivation and Context

https://ebce-lyrasis.atlassian.net/browse/PP-1914

How Has This Been Tested?

Unit tests have been updated.

Checklist

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@dbernstein dbernstein marked this pull request as draft November 21, 2024 03:57
@dbernstein dbernstein marked this pull request as ready for review November 21, 2024 18:36
@dbernstein dbernstein force-pushed the PP-1914-remove-collection-facet branch from 2cef11b to f833605 Compare November 21, 2024 18:39
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.01%. Comparing base (1d1b4eb) to head (f833605).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2182   +/-   ##
=======================================
  Coverage   91.01%   91.01%           
=======================================
  Files         361      361           
  Lines       41205    41172   -33     
  Branches     8849     8840    -9     
=======================================
- Hits        37504    37474   -30     
+ Misses       2425     2424    -1     
+ Partials     1276     1274    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jonathangreen jonathangreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

We also need a follow up PR for this, that will go into the release after this one to clean the old settings out of our existing library configurations. They won't cause any issues, but its good to clean them out of the json field before we forget about them.

@jonathangreen jonathangreen added the cleanup migration PR that will need a cleanup migration once its been fully deployed label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup migration PR that will need a cleanup migration once its been fully deployed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants