fix(pos): fix mismatch between buffer strings and POS tags #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the PartOfSpeech struct had both a
Tagand aBuffield, a stringified version of theBufvalue from FlatBuffers was being used to locate the POS during lookups. If this differed from theTagin the struct, then the POS wouldn't be found.This PR updates
Tagto be a computed value based on the stringified version of the FlatBuffer's enum (Buf) and replaces all underscores with dashes.Breaking change: the "abbrev" label has been changed to the shorter "abv" to match FlatBuffers
Closes #551