Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Objects and Object Constructors: setPrototypeOf() not explained properly #28633

Open
2 of 3 tasks
mahmoudmerghani opened this issue Aug 14, 2024 · 10 comments · May be fixed by #29465
Open
2 of 3 tasks

Objects and Object Constructors: setPrototypeOf() not explained properly #28633

mahmoudmerghani opened this issue Aug 14, 2024 · 10 comments · May be fixed by #29465
Assignees
Labels
Content: JavaScript Involves the JavaScript course Status: Help Wanted This issue can be assigned to other contributors

Comments

@mahmoudmerghani
Copy link

Checks

Describe your suggestion

The lesson doesn't explain setPrototypeOf() thoroughly, it doesn't make it clear that Object.setPrototypeOf(Player.prototype, Person.prototype); is like Player.prototype.__proto__ = Person.prototype
and the explanation of why Player.prototype = Person.prototype doesn't work is not clear

Path

Node / JS

Lesson Url

https://www.theodinproject.com/lessons/node-path-javascript-objects-and-object-constructors

(Optional) Discord Name

No response

(Optional) Additional Comments

No response

@KevinMulhern
Copy link
Member

Thanks @mahmoudmerghani, do you have any suggestions on how we can make it clearer?

@mahmoudmerghani
Copy link
Author

diagrams that show the object hierarchy would be helpful. and clarifying the distinction between an instance object prototype which is the constructor prototype property and the prototype of that same prototype. also the difference between the internal prototype of a constructor [[prototype]] and the property prototype.

Copy link

This issue is stale because it has had no activity for the last 30 days.

@github-actions github-actions bot added the Status: Stale This issue/PR has been inactive for over 30 days and will be closed if inactivity continues label Sep 18, 2024
@CouchofTomato
Copy link
Member

I'm happy to open this up to anyone who thinks they have a soution for it

@CouchofTomato CouchofTomato added Status: Help Wanted This issue can be assigned to other contributors Content: JavaScript Involves the JavaScript course and removed Status: Stale This issue/PR has been inactive for over 30 days and will be closed if inactivity continues labels Sep 18, 2024
Copy link

This issue is stale because it has had no activity for the last 30 days.

@github-actions github-actions bot added the Status: Stale This issue/PR has been inactive for over 30 days and will be closed if inactivity continues label Oct 19, 2024
@dekr1sh
Copy link
Contributor

dekr1sh commented Dec 27, 2024

@CouchofTomato I can take this up if no one's assigned

@github-actions github-actions bot removed the Status: Stale This issue/PR has been inactive for over 30 days and will be closed if inactivity continues label Dec 28, 2024
Copy link

This issue is stale because it has had no activity for the last 30 days.

@github-actions github-actions bot added the Status: Stale This issue/PR has been inactive for over 30 days and will be closed if inactivity continues label Jan 27, 2025
@CouchofTomato
Copy link
Member

Hey @dekr1sh

Apologies. I've had a few things on. Do you still want to work on this?

@github-actions github-actions bot removed the Status: Stale This issue/PR has been inactive for over 30 days and will be closed if inactivity continues label Feb 8, 2025
@dekr1sh
Copy link
Contributor

dekr1sh commented Feb 9, 2025

@CouchofTomato I'd be happy to :)

@CouchofTomato
Copy link
Member

@dekr1sh I've assigned it to you. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: JavaScript Involves the JavaScript course Status: Help Wanted This issue can be assigned to other contributors
Projects
None yet
4 participants