-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Objects and Object Constructors: setPrototypeOf() not explained properly #28633
Comments
Thanks @mahmoudmerghani, do you have any suggestions on how we can make it clearer? |
diagrams that show the object hierarchy would be helpful. and clarifying the distinction between an instance object prototype which is the constructor prototype property and the prototype of that same prototype. also the difference between the internal prototype of a constructor [[prototype]] and the property prototype. |
This issue is stale because it has had no activity for the last 30 days. |
I'm happy to open this up to anyone who thinks they have a soution for it |
This issue is stale because it has had no activity for the last 30 days. |
@CouchofTomato I can take this up if no one's assigned |
This issue is stale because it has had no activity for the last 30 days. |
Hey @dekr1sh Apologies. I've had a few things on. Do you still want to work on this? |
@CouchofTomato I'd be happy to :) |
@dekr1sh I've assigned it to you. Thanks :) |
Checks
Describe your suggestion
The lesson doesn't explain
setPrototypeOf()
thoroughly, it doesn't make it clear thatObject.setPrototypeOf(Player.prototype, Person.prototype);
is likePlayer.prototype.__proto__ = Person.prototype
and the explanation of why
Player.prototype = Person.prototype
doesn't work is not clearPath
Node / JS
Lesson Url
https://www.theodinproject.com/lessons/node-path-javascript-objects-and-object-constructors
(Optional) Discord Name
No response
(Optional) Additional Comments
No response
The text was updated successfully, but these errors were encountered: