Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several bug fixes and enhancements #2

Open
mdenchev opened this issue Dec 1, 2021 · 0 comments
Open

Several bug fixes and enhancements #2

mdenchev opened this issue Dec 1, 2021 · 0 comments

Comments

@mdenchev
Copy link

mdenchev commented Dec 1, 2021

Hi @TheNeikos, in my fork I have a couple of bug fixes and a few small enhancements. While I tried to separate my commits cleanly I didn't do a great job as I didn't quite know what I was doing initially, but the changes should still be well labeled in my fork. I'll create PRs for them once 0.6 is out, if you're interested in contributions. The changes are dependent on this PR TheNeikos/aseprite-reader#2.

Bug fixes:

  • Animations via tags would fail if the current frame is not one of the frames for that tag
  • Loading multiple ase files didn't work due to clobbering the texture atlas handle

Enhancements:

  • Logic for handling tag switching
  • Method for checking which tag is currently running

Thanks for creating the lib, it's the most convenient way to handle sprite animations I've come across for Bevy so far!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant