Effects not activated 1.20.6

[Samlegamer]

Hello I recently wanted to port my mod that worked in 1.20 up to 1.20.4 to 1.20.6, the problem is that when I add the effect to the entity nothing happens, I do not know if I am required to go through the function initCapabilities seen here: https://docs.illusivesoulworks.com/curios/items/curio-creation
I specify that everything works in 1.20.6:

public class PotionRingItem extends Item implements ICurioItem
{
	public PRTypes eff;
	
	public PotionRingItem(Properties p_41383_, PRTypes effect)
	{
		super(p_41383_);
		this.eff = effect;
		
	}
	
	public boolean isFoil(ItemStack p_77636_1_)
	{
		if(eff != PRTypes.none)
		{
			return true;
		}
	    return false;
	}
	
	@Override
	public void curioTick(SlotContext slotContext, ItemStack stack)
	{
		switch(eff)
		{
		case strength:			
			reloadEffect(slotContext.entity(), MobEffects.DAMAGE_BOOST);
			break;
		case speed:
			reloadEffect(slotContext.entity(), MobEffects.MOVEMENT_SPEED);
			break;
		case resistance:
			reloadEffect(slotContext.entity(), MobEffects.DAMAGE_RESISTANCE);
			break;
		case jump:
			reloadEffect(slotContext.entity(), MobEffects.JUMP);
			break;
		case haste:
			reloadEffect(slotContext.entity(), MobEffects.DIG_SPEED);
			break;
		case regeneration:
			reloadEffect(slotContext.entity(), MobEffects.REGENERATION);
			break;
		case growing:
			reloadEffect(slotContext.entity(), Holder.direct(PotionRing.growing.get()));
			break;
		case shrinking:
			reloadEffect(slotContext.entity(), Holder.direct(PotionRing.shrinking.get()));
			break;
		case widening:
			reloadEffect(slotContext.entity(), Holder.direct(PotionRing.widening.get()));
			break;
		case thinning:
			reloadEffect(slotContext.entity(), Holder.direct(PotionRing.thinning.get()));
			break;
		case none:
			break;
		}
	}
	
	@Override
	public void onEquip(SlotContext slotContext, ItemStack prevStack, ItemStack stack)
	{
		switch(eff)
		{
			case strength:			
				AddEffect(slotContext, MobEffects.DAMAGE_BOOST);
				break;
			case speed:
				AddEffect(slotContext, MobEffects.MOVEMENT_SPEED);
				break;
			case resistance:
				AddEffect(slotContext, MobEffects.DAMAGE_RESISTANCE);
				break;
			case jump:
				AddEffect(slotContext, MobEffects.JUMP);
				break;
			case haste:
				AddEffect(slotContext, MobEffects.DIG_SPEED);
				break;
			case regeneration:
				AddEffect(slotContext, MobEffects.REGENERATION);
				break;
			case growing:
				AddEffect(slotContext, Holder.direct(PotionRing.growing.get()));
				break;
			case shrinking:
				AddEffect(slotContext, Holder.direct(PotionRing.shrinking.get()));
				break;
			case widening:
				AddEffect(slotContext, Holder.direct(PotionRing.widening.get()));
				break;
			case thinning:
				AddEffect(slotContext, Holder.direct(PotionRing.thinning.get()));
				break;
			case none:
				break;
		}
	}

    @Override
    public boolean canUnequip(SlotContext slotContext, ItemStack stack)
    {
    	switch(eff)
		{
		case strength:
			DeleteEffect(slotContext.entity(), MobEffects.DAMAGE_BOOST);
			break;
		case speed:
			DeleteEffect(slotContext.entity(), MobEffects.MOVEMENT_SPEED);
			break;
		case resistance:
			DeleteEffect(slotContext.entity(), MobEffects.DAMAGE_RESISTANCE);
			break;
		case jump:
			DeleteEffect(slotContext.entity(), MobEffects.JUMP);
			break;
		case haste:
			DeleteEffect(slotContext.entity(), MobEffects.DIG_SPEED);
			break;
		case regeneration:
			DeleteEffect(slotContext.entity(), MobEffects.REGENERATION);
			break;
		case growing:
			DeleteEffect(slotContext.entity(), Holder.direct(PotionRing.growing.get()));
			break;
		case shrinking:
			DeleteEffect(slotContext.entity(), Holder.direct(PotionRing.shrinking.get()));
			break;
		case widening:
			DeleteEffect(slotContext.entity(), Holder.direct(PotionRing.widening.get()));
			break;
		case thinning:
			DeleteEffect(slotContext.entity(), Holder.direct(PotionRing.thinning.get()));
			break;
		case none:
			break;
		}
    	    	
    	return eff.toString() != null;
    }
    
    private void AddEffect(SlotContext slotContext, Holder<MobEffect> mbEff)
    {
    	if(!slotContext.entity().hasEffect(mbEff))
		{
            MobEffectInstance effectInstance = new MobEffectInstance(mbEff, 240, 0);
            if(slotContext.entity().level().isClientSide()) effectInstance.getDuration();
            slotContext.entity().addEffect(effectInstance);
		}
		else if(CuriosApi.getCuriosInventory(slotContext.entity()).resolve().get().findCurios(this).size() == 2)
		{
			MobEffectInstance effectInstance = new MobEffectInstance(mbEff, 240, 1);
			if(slotContext.entity().level().isClientSide()) effectInstance.getDuration();
			slotContext.entity().addEffect(effectInstance);
		}
    }
    
    private void reloadEffect(LivingEntity livingEntity, Holder<MobEffect> mbEff)
	{
    	int baseDuration = 240;
	    int newDuration1 = baseDuration;
	    int newDuration2 = baseDuration;

	    if (livingEntity.hasEffect(mbEff)) {
	    	MobEffectInstance currentEffect = livingEntity.getEffect(mbEff);
	        int currentDuration = currentEffect.getDuration();

	        if (CuriosApi.getCuriosInventory(livingEntity).resolve().get().findCurios(this).size() == 1) {
	            newDuration1 += currentDuration;
	        } else if (CuriosApi.getCuriosInventory(livingEntity).resolve().get().findCurios(this).size() == 2) {
	            newDuration2 += currentDuration;
	        }
	    }

	    MobEffectInstance effA1 = new MobEffectInstance(mbEff, newDuration1, 0, false, false);
	    MobEffectInstance effA2 = new MobEffectInstance(mbEff, newDuration2, 1, false, false);

	    if (CuriosApi.getCuriosInventory(livingEntity).resolve().get().findCurios(this).size() == 1) {
	        livingEntity.addEffect(effA1);
	    } else if (CuriosApi.getCuriosInventory(livingEntity).resolve().get().findCurios(this).size() == 2) {
	        livingEntity.addEffect(effA2);
	    }
	}
    
    private void DeleteEffect(LivingEntity livingEntity, Holder<MobEffect> mbEff)
    {
    	if(livingEntity.hasEffect(mbEff))
		{
			livingEntity.removeEffect(mbEff);
		}
    }
}

[TheIllusiveC4]

Are you on Forge or NeoForge?

I would suggest adding some breakpoints or debug lines to see if your item's code is being called and then adjust appropriately. If none if it is being called, it may be a problem with the initialization of the item.

[Samlegamer]

I'm on Forge, and I was wondering if this had anything to do with item registration?

public class PRItemsRegistry
{
	public static final DeferredRegister<Item> ITEMS_REGISTRY = DeferredRegister.create(ForgeRegistries.ITEMS, PotionRing.MODID);

	private static final Item.Properties RING = new Item.Properties().stacksTo(1);
	
	public static final RegistryObject<Item> POTION_RING = ITEMS_REGISTRY.register("potion_ring", () -> new PotionRingItem(RING, PRTypes.none));
	public static final RegistryObject<Item> RING_OF_REGENERATION = ITEMS_REGISTRY.register("ring_of_regeneration", () -> new PotionRingItem(RING, PRTypes.regeneration));
	public static final RegistryObject<Item> RING_OF_HASTE = ITEMS_REGISTRY.register("ring_of_haste", () -> new PotionRingItem(RING, PRTypes.haste));
	public static final RegistryObject<Item> RING_OF_JUMP_BOOST = ITEMS_REGISTRY.register("ring_of_jump_boost", () -> new PotionRingItem(RING, PRTypes.jump));
	public static final RegistryObject<Item> RING_OF_RESISTANCE = ITEMS_REGISTRY.register("ring_of_resistance", () -> new PotionRingItem(RING, PRTypes.resistance));
	public static final RegistryObject<Item> RING_OF_SPEED = ITEMS_REGISTRY.register("ring_of_speed", () -> new PotionRingItem(RING, PRTypes.speed));
	public static final RegistryObject<Item> RING_OF_STRENGH = ITEMS_REGISTRY.register("ring_of_strengh", () -> new PotionRingItem(RING, PRTypes.strength));

[TheIllusiveC4]

The initialization seems fine to me, but that's based just on the snippet you've shown here.

[Samlegamer]

@Mod(value = PotionRing.MODID)
@Mod.EventBusSubscriber(modid = PotionRing.MODID, bus = Mod.EventBusSubscriber.Bus.MOD)
public class PotionRing
{
	public static final String MODID = "potionring";
	public static final Logger log = LogManager.getLogger();
	
	public static final RegistryObject<MobEffect> growing = RegistryObject.create(new ResourceLocation("sizeshiftingpotions:growing"), ForgeRegistries.MOB_EFFECTS);
	public static final RegistryObject<MobEffect> shrinking = RegistryObject.create(new ResourceLocation("sizeshiftingpotions:shrinking"), ForgeRegistries.MOB_EFFECTS);
	public static final RegistryObject<MobEffect> widening = RegistryObject.create(new ResourceLocation("sizeshiftingpotions:widening"), ForgeRegistries.MOB_EFFECTS);
	public static final RegistryObject<MobEffect> thinning = RegistryObject.create(new ResourceLocation("sizeshiftingpotions:thinning"), ForgeRegistries.MOB_EFFECTS);
	
	public PotionRing()
	{
		FMLJavaModLoadingContext.get().getModEventBus().addListener(this::addToTab);
		//PRItemsRegistry.addons();
		PRItemsRegistry.ITEMS_REGISTRY.register(FMLJavaModLoadingContext.get().getModEventBus());
		log.info("Potion Ring - REFORGED is Charged");
	}
	
	private void addToTab(BuildCreativeModeTabContentsEvent event)
	{
	    if (event.getTabKey() == CreativeModeTabs.FOOD_AND_DRINKS)
	    {
	    	event.accept(PRItemsRegistry.POTION_RING);
	    	/*event.accept(PRItemsRegistry.RING_OF_REGENERATION);
	    	event.accept(PRItemsRegistry.RING_OF_HASTE);
	    	event.accept(PRItemsRegistry.RING_OF_JUMP_BOOST);
	    	event.accept(PRItemsRegistry.RING_OF_RESISTANCE);
	    	event.accept(PRItemsRegistry.RING_OF_SPEED);
	    	event.accept(PRItemsRegistry.RING_OF_STRENGH);
	    	if(ModList.get().isLoaded("sizeshiftingpotions"))
			{
		    	event.accept(PRItemsRegistry.ring_of_growing);
		    	event.accept(PRItemsRegistry.ring_of_shrinking);
		    	event.accept(PRItemsRegistry.ring_of_widening);
		    	event.accept(PRItemsRegistry.ring_of_thinning);
			}*/
	    }
	}
}

[TheIllusiveC4]

I think that seems fine to me. If there's no problem with initialization, then you'll need to set up some breakpoints to see if the code is being called or where it's failing to apply the effects.

[Samlegamer]

As NeoForge is quite similar for the time being, I wanted to try wearing this mod on it, and the effects are very well applied.

[TheIllusiveC4]

I figured out that this is a bug with the Forge version. This should be fixed now in the 8.0.0-beta.5+1.20.6 version.