Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.15/1.16] Item Inventory example bugged #69

Open
capnkirok opened this issue Feb 27, 2021 · 3 comments
Open

[1.15/1.16] Item Inventory example bugged #69

capnkirok opened this issue Feb 27, 2021 · 3 comments

Comments

@capnkirok
Copy link

capnkirok commented Feb 27, 2021

I used the Item Inventory code from your tutorial as a base for Inventory Pets Chest and Feed Bag pets, but then ran into a nasty and unsolved issue:
MinecraftForge/MinecraftForge#4594

Basically, using any inventory item with similar functionality when on a server in creative mode clears the contents of the itemstack inventory. I would remove this example since it has caused significant frustration from players, and does not look like will be solved anytime soon by Minecraft or Forge.

Since you've written this tutorial, all of the above mods, including Botania, have rewritten their code completely as a result.

@capnkirok capnkirok changed the title Item Inventory example bugged [1.15/1.16] Item Inventory example bugged Feb 27, 2021
@TheGreyGhost
Copy link
Owner

Howdy
That's annoying. The whole capability system is a bit underbaked IMHO and if Botania have refactored to get rid of it then that's a grim sign.

I'll have a look (in the next week with any luck) and try to figure out the best way forward

Thanks for letting me know!

-TGG

@capnkirok
Copy link
Author

capnkirok commented Apr 11, 2021

Following up on this. I ended up using a similar approach to SimplyBackpacks, which works very well (and also doesn't involve core mods or reflection)
https://github.com/Flanks255/simplybackpacks/tree/master/src/main/java/com/flanks255/simplybackpacks

@TheGreyGhost
Copy link
Owner

Howdy
Thanks for the updated info. When I get a chance I'll review those and either replace the flowerbag or at least cross-reference it with a warning
Cheers
TGG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants