Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyuploadtool appends to assets instead of recreating release #8

Open
srevinsaju opened this issue Oct 24, 2021 · 4 comments
Open

pyuploadtool appends to assets instead of recreating release #8

srevinsaju opened this issue Oct 24, 2021 · 4 comments

Comments

@srevinsaju
Copy link
Contributor

I am not sure if this is configurable yet,

In my repository, workflow, it appends to the assets list when the asset has a different name, when compared to those which already exist on the release.

I understand this is the design of pyuploadtool, but is it possible to recreate the release? Use cases are when version is included in the filename on GitHub release.

@TheAssassin
Copy link
Owner

The original idea was to be able to upload to a release from different workflows. I am not sure but I think there is a commit check at least. I don't see any good way to, like, compare hashes against the existing files. That doesn't seem such a great idea anyway. What's your use case?

In any case, we can make this configurable.

@srevinsaju
Copy link
Contributor Author

my workflow clones another repository, fetches the version from it using git describe and creates release assets and pushed it to GitHub releases using pyuploadtool. This workflow runs on a schedule, like... runs every one week for example. So yea, if I have pushed other commits to the builder repo, then it would create the release correctly. This is similar to the workflow of prebuilt-kf5 but just that it runs on a schedule.

@TheAssassin
Copy link
Owner

So either we add an option to forcibly recreate the release, or you delete the release in some other way beforehand. Want to file a PR?

I wouldn't make this behavior the default to avoid confusion among existing pyuploadtool users. I hardly use the original workflow anymore anyway, I'd rather have a "synchronized" upload (i.e., collecting artifacts first, uploading them after all builds finished), which is generally more reliable.

@srevinsaju
Copy link
Contributor Author

Yes sure, I can work on it.

I'd rather have a "synchronized" upload (i.e., collecting artifacts first, uploading them after all builds finished), which is generally more reliable.

Calls for an actions/upload-artifact replacement too haha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants