You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When you add a new feature always create an issue first, this allows others to comment and give you tips. It will also help us keep track of what people are adding and with new releases helps us to write new release notes and give you credit for your work.
44
44
45
-
Secondly always work in a branch, never work on the master branch. Keep your master branch in sync with the master of the official Simple-Static-Website repository. This makes the pull requests (you do want your work to be in the main branch right?) easier for us.
45
+
Secondly, always work in a branch, never work on the master branch. Keep your master branch in sync with the master of the official Simple-Static-Website repository. This makes the pull requests (you do want your work to be in the main branch right?) easier for us.
46
46
47
-
Finally try to keep your branches focused on fixing/adding only one feature and try not fall in the trap of doing a lot of things in a single branch. This will not only make it harder for us to process your pull request but makes it take longer before you can submit your pull request. Small pull requests are more likely to be looked at faster and pulled into the main branch faster.
47
+
Finally, try to keep your branches focused on fixing/adding only one feature and try not to fall in the trap of doing a lot of things in a single branch. This will not only make it harder for us to process your pull request but makes it take longer before you can submit your pull request. Small pull requests are more likely to be looked at faster and pulled into the main branch faster.
48
48
49
-
Here is a simplified workflow on how add a new feature:
49
+
Here is a simplified workflow on how to add a new feature:
50
50
51
51
### Get latest version
52
52
@@ -61,19 +61,19 @@ git push
61
61
62
62
### Create a branch to do your work.
63
63
64
-
A good practice is to call the branch in the form of GH-<issue-number> followed by the title of the issue. This makes it easier to find out the issue you are trying to solve and helps us to understand what is done in the branch. Calling a branch my-work is confusing. Names of branch can not have a space, and should be replaced with a hyphen.
64
+
A good practice is to call the branch in the form of GH-<issue-number> followed by the title of the issue. This makes it easier to find out the issue you are trying to solve and helps us to understand what is done in the branch. Calling a branch my-work is confusing. Names of a branch can not have a space, and should be replaced with a hyphen.
65
65
66
66
```
67
67
git checkout -b GH-issuenumber-title-of-issue
68
68
```
69
69
70
70
### Work and commit
71
71
72
-
Do you work, and commit as you see fit.Make your commit messages helpful.
72
+
Do you work, and commit as you see fit.Make your commit messages helpful.
73
73
74
74
### Push your changes up to GitHub.
75
75
76
-
If this is the first time pushing to GitHub you will need to extended command, other wise you can simply do a `git push`.
76
+
If this is the first time pushing to GitHub you will need to extended command, otherwise, you can simply do a `git push`.
0 commit comments