You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
That code is automatically generated by emscripten. It looks like they're just unused variables and redundant boolean evaluations. We'll clean it up programatically to get rid of those warnings!
Hey, I've tried to rectify the issues but it doesn't work. Apparently, even though there are unused variables and dubious boolean expressions, WASM needs this code the way Emscripten generates it. I'm not happy with this, but I guess that fiddling with this auto-generated code is not an option.
I might be wrong, but I assume that the reason for using a code reviewer is to ensure the quality and maintainability of the repository, avoiding flaws and smells; in the case of this code, it is an output automatically generated by Emscripten (i.e. there is no maintenance and no chance of it being wrong), so maybe it shouldn't be evaluated as if it were code written by us.
I've checked the lgtm documentation and it looks like there are mechanisms to ignore specific files. Do you think this solution would work for Three for this specific file? Sorry for the inconvenience!
We use lgtm in three.js and we've noticed
web-ifc-api.js
has a few warnings:https://lgtm.com/projects/g/mrdoob/three.js/snapshot/0d37b6de513cc0e33ff7184594bce9b821509152/files/examples/jsm/loaders/ifc/web-ifc-api.js?sort=name&dir=ASC&mode=heatmap
The text was updated successfully, but these errors were encountered: