fix: Delete directory recursive should delete files in subfolders #422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbreuss
reviewed
Nov 16, 2023
vbreuss
reviewed
Nov 16, 2023
|
This is addressed in release v2.5.1. |
mergify bot
referenced
this pull request
in Testably/Testably.Abstractions.FluentAssertions
Nov 16, 2023
#65) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [Testably.Abstractions.Testing](https://github.com/Testably/Testably.Abstractions) | `2.5.0` -> `2.5.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>Testably/Testably.Abstractions (Testably.Abstractions.Testing)</summary> ### [`v2.5.1`](https://github.com/Testably/Testably.Abstractions/releases/tag/v2.5.1) #### What's Changed - chore(deps): update testably.abstractions packages to v2.5.0 by [@​renovate](https://github.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/410](https://github.com/Testably/Testably.Abstractions/pull/410) - fix: support relative path with drive information in `Path.GetFullPath` by [@​vbreuss](https://github.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/411](https://github.com/Testably/Testably.Abstractions/pull/411) - chore(deps): update xunit-dotnet monorepo by [@​renovate](https://github.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/412](https://github.com/Testably/Testably.Abstractions/pull/412) - chore(deps): update dependency xunit to v2.5.3 by [@​renovate](https://github.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/413](https://github.com/Testably/Testably.Abstractions/pull/413) - chore(deps): update actions/checkout digest to [`b4ffde6`](https://github.com/Testably/Testably.Abstractions/commit/b4ffde6) by [@​renovate](https://github.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/414](https://github.com/Testably/Testably.Abstractions/pull/414) - fix: `Directory.EnumerateDirectories` with trailing slash in `path` by [@​vbreuss](https://github.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/415](https://github.com/Testably/Testably.Abstractions/pull/415) - chore(deps): update dependency xunit to v2.6.0 by [@​renovate](https://github.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/416](https://github.com/Testably/Testably.Abstractions/pull/416) - chore(deps): update dependency xunit to v2.6.1 by [@​renovate](https://github.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/417](https://github.com/Testably/Testably.Abstractions/pull/417) - chore(deps): update dependency microsoft.net.test.sdk to v17.8.0 by [@​renovate](https://github.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/418](https://github.com/Testably/Testably.Abstractions/pull/418) - feat: enable support for .NET 8.0 by [@​vbreuss](https://github.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/389](https://github.com/Testably/Testably.Abstractions/pull/389) - chore(deps): update danielpalme/reportgenerator-github-action action to v5.2.0 by [@​renovate](https://github.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/420](https://github.com/Testably/Testably.Abstractions/pull/420) - feat: update references to net8 by [@​vbreuss](https://github.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/421](https://github.com/Testably/Testably.Abstractions/pull/421) - fix: Delete directory recursive should delete files in subfolders by [@​ElStefan](https://github.com/ElStefan) in [https://github.com/Testably/Testably.Abstractions/pull/422](https://github.com/Testably/Testably.Abstractions/pull/422) **Full Changelog**: Testably/Testably.Abstractions@v2.5.0...v2.5.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Testably/Testably.Abstractions.FluentAssertions). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
mergify bot
referenced
this pull request
in Testably/Testably.Abstractions.FluentAssertions
Nov 16, 2023
…5.1 (#64) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [Testably.Abstractions.Interface](https://github.com/Testably/Testably.Abstractions) | `2.5.0` -> `2.5.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>Testably/Testably.Abstractions (Testably.Abstractions.Interface)</summary> ### [`v2.5.1`](https://github.com/Testably/Testably.Abstractions/releases/tag/v2.5.1) #### What's Changed - chore(deps): update testably.abstractions packages to v2.5.0 by [@​renovate](https://github.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/410](https://github.com/Testably/Testably.Abstractions/pull/410) - fix: support relative path with drive information in `Path.GetFullPath` by [@​vbreuss](https://github.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/411](https://github.com/Testably/Testably.Abstractions/pull/411) - chore(deps): update xunit-dotnet monorepo by [@​renovate](https://github.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/412](https://github.com/Testably/Testably.Abstractions/pull/412) - chore(deps): update dependency xunit to v2.5.3 by [@​renovate](https://github.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/413](https://github.com/Testably/Testably.Abstractions/pull/413) - chore(deps): update actions/checkout digest to [`b4ffde6`](https://github.com/Testably/Testably.Abstractions/commit/b4ffde6) by [@​renovate](https://github.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/414](https://github.com/Testably/Testably.Abstractions/pull/414) - fix: `Directory.EnumerateDirectories` with trailing slash in `path` by [@​vbreuss](https://github.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/415](https://github.com/Testably/Testably.Abstractions/pull/415) - chore(deps): update dependency xunit to v2.6.0 by [@​renovate](https://github.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/416](https://github.com/Testably/Testably.Abstractions/pull/416) - chore(deps): update dependency xunit to v2.6.1 by [@​renovate](https://github.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/417](https://github.com/Testably/Testably.Abstractions/pull/417) - chore(deps): update dependency microsoft.net.test.sdk to v17.8.0 by [@​renovate](https://github.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/418](https://github.com/Testably/Testably.Abstractions/pull/418) - feat: enable support for .NET 8.0 by [@​vbreuss](https://github.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/389](https://github.com/Testably/Testably.Abstractions/pull/389) - chore(deps): update danielpalme/reportgenerator-github-action action to v5.2.0 by [@​renovate](https://github.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/420](https://github.com/Testably/Testably.Abstractions/pull/420) - feat: update references to net8 by [@​vbreuss](https://github.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/421](https://github.com/Testably/Testably.Abstractions/pull/421) - fix: Delete directory recursive should delete files in subfolders by [@​ElStefan](https://github.com/ElStefan) in [https://github.com/Testably/Testably.Abstractions/pull/422](https://github.com/Testably/Testably.Abstractions/pull/422) **Full Changelog**: Testably/Testably.Abstractions@v2.5.0...v2.5.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Testably/Testably.Abstractions.FluentAssertions). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
mergify bot
referenced
this pull request
Nov 16, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [Testably.Abstractions](https://github.com/Testably/Testably.Abstractions) | `2.5.0` -> `2.5.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [Testably.Abstractions.Testing](https://github.com/Testably/Testably.Abstractions) | `2.5.0` -> `2.5.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>Testably/Testably.Abstractions (Testably.Abstractions)</summary> ### [`v2.5.1`](https://github.com/Testably/Testably.Abstractions/releases/tag/v2.5.1) ##### What's Changed - chore(deps): update testably.abstractions packages to v2.5.0 by [@​renovate](https://github.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/410](https://github.com/Testably/Testably.Abstractions/pull/410) - fix: support relative path with drive information in `Path.GetFullPath` by [@​vbreuss](https://github.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/411](https://github.com/Testably/Testably.Abstractions/pull/411) - chore(deps): update xunit-dotnet monorepo by [@​renovate](https://github.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/412](https://github.com/Testably/Testably.Abstractions/pull/412) - chore(deps): update dependency xunit to v2.5.3 by [@​renovate](https://github.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/413](https://github.com/Testably/Testably.Abstractions/pull/413) - chore(deps): update actions/checkout digest to [`b4ffde6`](https://github.com/Testably/Testably.Abstractions/commit/b4ffde6) by [@​renovate](https://github.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/414](https://github.com/Testably/Testably.Abstractions/pull/414) - fix: `Directory.EnumerateDirectories` with trailing slash in `path` by [@​vbreuss](https://github.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/415](https://github.com/Testably/Testably.Abstractions/pull/415) - chore(deps): update dependency xunit to v2.6.0 by [@​renovate](https://github.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/416](https://github.com/Testably/Testably.Abstractions/pull/416) - chore(deps): update dependency xunit to v2.6.1 by [@​renovate](https://github.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/417](https://github.com/Testably/Testably.Abstractions/pull/417) - chore(deps): update dependency microsoft.net.test.sdk to v17.8.0 by [@​renovate](https://github.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/418](https://github.com/Testably/Testably.Abstractions/pull/418) - feat: enable support for .NET 8.0 by [@​vbreuss](https://github.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/389](https://github.com/Testably/Testably.Abstractions/pull/389) - chore(deps): update danielpalme/reportgenerator-github-action action to v5.2.0 by [@​renovate](https://github.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/420](https://github.com/Testably/Testably.Abstractions/pull/420) - feat: update references to net8 by [@​vbreuss](https://github.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/421](https://github.com/Testably/Testably.Abstractions/pull/421) - fix: Delete directory recursive should delete files in subfolders by [@​ElStefan](https://github.com/ElStefan) in [https://github.com/Testably/Testably.Abstractions/pull/422](https://github.com/Testably/Testably.Abstractions/pull/422) **Full Changelog**: v2.5.0...v2.5.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Testably/Testably.Abstractions). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
MockFileSystem.Directory.Deletewithrecursive: truethrows aDirectoryNotEmptyExceptionwhen trying to delete a directory with files in it.As the documentation of
Directory.Delete(String, Boolean)indicates, the method should actually try to delete all files and subfolders instead.