From e14df85b2179fdf8c45564e0b7677e81b2ee1644 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Valentin=20Breu=C3=9F?= Date: Sun, 10 Sep 2023 11:12:34 +0200 Subject: [PATCH] Use "Exists" and "NotExists" fluent assertions --- Directory.Packages.props | 2 +- .../FileSystemInitializerExtensionsTests.cs | 2 +- .../Directory/CreateDirectoryTests.cs | 6 ++-- .../FileSystem/Directory/DeleteTests.cs | 4 +-- .../Directory/ResolveLinkTargetTests.cs | 11 ++++---- .../FileSystem/Directory/Tests.cs | 2 +- .../DirectoryInfo/CreateSubdirectoryTests.cs | 10 +++---- .../FileSystem/DirectoryInfo/CreateTests.cs | 28 +++++++++---------- .../FileSystem/DirectoryInfo/DeleteTests.cs | 18 ++++++------ .../FileSystem/DirectoryInfo/ExistsTests.cs | 28 +++++++++---------- .../FileSystem/DirectoryInfo/Tests.cs | 6 ++-- .../FileSystem/DirectoryInfoFactory/Tests.cs | 2 +- .../FileSystem/File/ResolveLinkTargetTests.cs | 10 +++---- .../FileSystem/FileInfo/CopyToTests.cs | 10 +++---- .../FileSystem/FileInfo/CreateTests.cs | 16 +++++------ .../FileSystem/FileInfo/CreateTextTests.cs | 8 +++--- .../FileSystem/FileInfo/DeleteTests.cs | 6 ++-- .../FileSystem/FileInfo/ExistsTests.cs | 8 +++--- .../FileSystem/FileInfo/MoveToTests.cs | 8 +++--- .../FileSystem/FileInfo/OpenTests.cs | 2 +- .../FileSystem/FileInfo/ReplaceTests.cs | 14 +++++----- .../FileSystem/FileInfoFactory/Tests.cs | 2 +- .../FileSystemInfo/ResolveLinkTargetTests.cs | 8 +++--- 23 files changed, 106 insertions(+), 105 deletions(-) diff --git a/Directory.Packages.props b/Directory.Packages.props index 615d197fe..83901619d 100644 --- a/Directory.Packages.props +++ b/Directory.Packages.props @@ -37,7 +37,7 @@ - + diff --git a/Tests/Testably.Abstractions.Testing.Tests/FileSystemInitializerExtensionsTests.cs b/Tests/Testably.Abstractions.Testing.Tests/FileSystemInitializerExtensionsTests.cs index b0ee7e94f..75ae17061 100644 --- a/Tests/Testably.Abstractions.Testing.Tests/FileSystemInitializerExtensionsTests.cs +++ b/Tests/Testably.Abstractions.Testing.Tests/FileSystemInitializerExtensionsTests.cs @@ -160,7 +160,7 @@ public void Initialize_WithSubdirectory_ShouldExist(string directoryName) MockFileSystem> result = sut.Initialize().WithSubdirectory(directoryName); - result.Directory.Exists.Should().BeTrue(); + result.Directory.Should().Exist(); } [Theory] diff --git a/Tests/Testably.Abstractions.Tests/FileSystem/Directory/CreateDirectoryTests.cs b/Tests/Testably.Abstractions.Tests/FileSystem/Directory/CreateDirectoryTests.cs index 6b16919bc..423440521 100644 --- a/Tests/Testably.Abstractions.Tests/FileSystem/Directory/CreateDirectoryTests.cs +++ b/Tests/Testably.Abstractions.Tests/FileSystem/Directory/CreateDirectoryTests.cs @@ -237,9 +237,9 @@ public void CreateDirectory_ShouldCreateParentDirectories() result.Name.Should().Be(directoryLevel3); result.Parent!.Name.Should().Be(directoryLevel2); result.Parent.Parent!.Name.Should().Be(directoryLevel1); - result.Exists.Should().BeTrue(); - result.Parent.Exists.Should().BeTrue(); - result.Parent.Parent.Exists.Should().BeTrue(); + result.Should().Exist(); + result.Parent.Should().Exist(); + result.Parent.Parent.Should().Exist(); } #if NETFRAMEWORK diff --git a/Tests/Testably.Abstractions.Tests/FileSystem/Directory/DeleteTests.cs b/Tests/Testably.Abstractions.Tests/FileSystem/Directory/DeleteTests.cs index 8d1cee7ad..bd82ff1ed 100644 --- a/Tests/Testably.Abstractions.Tests/FileSystem/Directory/DeleteTests.cs +++ b/Tests/Testably.Abstractions.Tests/FileSystem/Directory/DeleteTests.cs @@ -43,7 +43,7 @@ public void Delete_FullPath_ShouldDeleteDirectory(string directoryName) FileSystem.Directory.Delete(result.FullName); FileSystem.Should().NotHaveDirectory(directoryName); - result.Exists.Should().BeFalse(); + result.Should().NotExist(); } [SkippableTheory] @@ -195,7 +195,7 @@ public void Delete_ShouldDeleteDirectory(string directoryName) FileSystem.Directory.Delete(directoryName); FileSystem.Should().NotHaveDirectory(directoryName); - result.Exists.Should().BeFalse(); + result.Should().NotExist(); } [SkippableTheory] diff --git a/Tests/Testably.Abstractions.Tests/FileSystem/Directory/ResolveLinkTargetTests.cs b/Tests/Testably.Abstractions.Tests/FileSystem/Directory/ResolveLinkTargetTests.cs index e46bc9fed..fa0f97fce 100644 --- a/Tests/Testably.Abstractions.Tests/FileSystem/Directory/ResolveLinkTargetTests.cs +++ b/Tests/Testably.Abstractions.Tests/FileSystem/Directory/ResolveLinkTargetTests.cs @@ -1,5 +1,6 @@ #if FEATURE_FILESYSTEM_LINK using System.IO; +using Testably.Abstractions.FluentAssertions; namespace Testably.Abstractions.Tests.FileSystem.Directory; @@ -32,7 +33,7 @@ public void ResolveLinkTarget_AbsolutePath_ShouldFollowSymbolicLink( FileSystem.Directory.ResolveLinkTarget(path, false); target!.FullName.Should().Be(targetFullPath); - target.Exists.Should().BeTrue(); + target.Should().Exist(); } [SkippableTheory] @@ -53,12 +54,12 @@ public void if (!Test.RunsOnLinux) { target!.FullName.Should().Be(targetFullPath); - target.Exists.Should().BeTrue(); + target.Should().Exist(); } else { target!.FullName.Should().Be(targetFullPath); - target.Exists.Should().BeFalse(); + target.Should().NotExist(); } } @@ -174,7 +175,7 @@ public void ResolveLinkTarget_RelativePath_ShouldFollowSymbolicLinkUnderWindows( FileSystem.Directory.ResolveLinkTarget(path, false); target!.FullName.Should().Be(targetFullPath); - target.Exists.Should().BeTrue(); + target.Should().Exist(); } [SkippableTheory] @@ -194,7 +195,7 @@ public void ResolveLinkTarget_TargetDeletedAfterLinkCreation_ShouldReturnNull( target!.FullName.Should().Be(targetFullPath); - target.Exists.Should().BeFalse(); + target.Should().NotExist(); } } #endif diff --git a/Tests/Testably.Abstractions.Tests/FileSystem/Directory/Tests.cs b/Tests/Testably.Abstractions.Tests/FileSystem/Directory/Tests.cs index 29b345af5..5074b1c34 100644 --- a/Tests/Testably.Abstractions.Tests/FileSystem/Directory/Tests.cs +++ b/Tests/Testably.Abstractions.Tests/FileSystem/Directory/Tests.cs @@ -13,7 +13,7 @@ public void CreateTempSubdirectory_ShouldCreateTheTemporaryDirectory() { IDirectoryInfo result = FileSystem.Directory.CreateTempSubdirectory(); - result.Exists.Should().BeTrue(); + result.Should().Exist(); } [SkippableTheory] diff --git a/Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfo/CreateSubdirectoryTests.cs b/Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfo/CreateSubdirectoryTests.cs index 56af81467..a0b0fdac9 100644 --- a/Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfo/CreateSubdirectoryTests.cs +++ b/Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfo/CreateSubdirectoryTests.cs @@ -31,12 +31,12 @@ public void CreateSubdirectory_MissingParent_ShouldCreateDirectory( string path, string subdirectory) { IDirectoryInfo sut = FileSystem.DirectoryInfo.New(path); - sut.Exists.Should().BeFalse(); + sut.Should().NotExist(); IDirectoryInfo result = sut.CreateSubdirectory(subdirectory); - sut.Exists.Should().BeFalse(); + sut.Should().NotExist(); FileSystem.Should().HaveDirectory(sut.FullName); - result.Exists.Should().BeTrue(); + result.Should().Exist(); FileSystem.Should().HaveDirectory(result.FullName); } @@ -48,9 +48,9 @@ public void CreateSubdirectory_ShouldCreateDirectory(string path, string subdire sut.Create(); IDirectoryInfo result = sut.CreateSubdirectory(subdirectory); - sut.Exists.Should().BeTrue(); + sut.Should().Exist(); FileSystem.Should().HaveDirectory(sut.FullName); - result.Exists.Should().BeTrue(); + result.Should().Exist(); FileSystem.Should().HaveDirectory(result.FullName); } } diff --git a/Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfo/CreateTests.cs b/Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfo/CreateTests.cs index 96e2b5522..8b7539939 100644 --- a/Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfo/CreateTests.cs +++ b/Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfo/CreateTests.cs @@ -29,15 +29,15 @@ public void Create_FileWithSameNameAlreadyExists_ShouldThrowIOException(string n public void Create_ShouldCreateDirectory(string path) { IDirectoryInfo sut = FileSystem.DirectoryInfo.New(path); - sut.Exists.Should().BeFalse(); + sut.Should().NotExist(); sut.Create(); #if NETFRAMEWORK // The DirectoryInfo is not updated in .NET Framework! - sut.Exists.Should().BeFalse(); + sut.Should().NotExist(); #else - sut.Exists.Should().BeTrue(); + sut.Should().Exist(); #endif FileSystem.Should().HaveDirectory(sut.FullName); } @@ -68,9 +68,9 @@ public void Create_ShouldCreateParentDirectories() result.Name.Should().Be(directoryLevel3); result.Parent!.Name.Should().Be(directoryLevel2); result.Parent.Parent!.Name.Should().Be(directoryLevel1); - result.Exists.Should().BeTrue(); - result.Parent.Exists.Should().BeTrue(); - result.Parent.Parent.Exists.Should().BeTrue(); + result.Should().Exist(); + result.Parent.Should().Exist(); + result.Parent.Parent.Should().Exist(); result.ToString().Should().Be(path); } @@ -81,23 +81,23 @@ public void Create_ShouldRefreshExistsCacheForCurrentItem_ExceptOnNetFramework(s IDirectoryInfo sut1 = FileSystem.DirectoryInfo.New(path); IDirectoryInfo sut2 = FileSystem.DirectoryInfo.New(path); IDirectoryInfo sut3 = FileSystem.DirectoryInfo.New(path); - sut1.Exists.Should().BeFalse(); - sut2.Exists.Should().BeFalse(); + sut1.Should().NotExist(); + sut2.Should().NotExist(); // Do not call Exists for `sut3` sut1.Create(); if (Test.IsNetFramework) { - sut1.Exists.Should().BeFalse(); - sut2.Exists.Should().BeFalse(); - sut3.Exists.Should().BeTrue(); + sut1.Should().NotExist(); + sut2.Should().NotExist(); + sut3.Should().Exist(); } else { - sut1.Exists.Should().BeTrue(); - sut2.Exists.Should().BeFalse(); - sut3.Exists.Should().BeTrue(); + sut1.Should().Exist(); + sut2.Should().NotExist(); + sut3.Should().Exist(); } FileSystem.Should().HaveDirectory(path); diff --git a/Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfo/DeleteTests.cs b/Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfo/DeleteTests.cs index ca409a9c1..1026b1228 100644 --- a/Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfo/DeleteTests.cs +++ b/Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfo/DeleteTests.cs @@ -12,7 +12,7 @@ public abstract partial class DeleteTests public void Delete_MissingDirectory_ShouldThrowDirectoryNotFoundException(string path) { IDirectoryInfo sut = FileSystem.DirectoryInfo.New(path); - sut.Exists.Should().BeFalse(); + sut.Should().NotExist(); Exception? exception = Record.Exception(() => { @@ -69,15 +69,15 @@ public void Delete_Recursive_WithSubdirectory_ShouldDeleteDirectoryWithContent( string subdirectoryPath = FileSystem.Path.Combine(path, subdirectory); FileSystem.Directory.CreateDirectory(subdirectoryPath); IDirectoryInfo sut = FileSystem.DirectoryInfo.New(path); - sut.Exists.Should().BeTrue(); + sut.Should().Exist(); sut.Delete(true); #if NETFRAMEWORK // The DirectoryInfo is not updated in .NET Framework! - sut.Exists.Should().BeTrue(); + sut.Should().Exist(); #else - sut.Exists.Should().BeFalse(); + sut.Should().NotExist(); #endif FileSystem.Should().NotHaveDirectory(sut.FullName); FileSystem.Should().NotHaveDirectory(subdirectoryPath); @@ -89,15 +89,15 @@ public void Delete_ShouldDeleteDirectory(string path) { FileSystem.Directory.CreateDirectory(path); IDirectoryInfo sut = FileSystem.DirectoryInfo.New(path); - sut.Exists.Should().BeTrue(); + sut.Should().Exist(); sut.Delete(); #if NETFRAMEWORK // The DirectoryInfo is not updated in .NET Framework! - sut.Exists.Should().BeTrue(); + sut.Should().Exist(); #else - sut.Exists.Should().BeFalse(); + sut.Should().NotExist(); #endif FileSystem.Should().NotHaveDirectory(sut.FullName); } @@ -109,7 +109,7 @@ public void Delete_WithSubdirectory_ShouldThrowIOException_AndNotDeleteDirectory { FileSystem.Directory.CreateDirectory(FileSystem.Path.Combine(path, subdirectory)); IDirectoryInfo sut = FileSystem.DirectoryInfo.New(path); - sut.Exists.Should().BeTrue(); + sut.Should().Exist(); Exception? exception = Record.Exception(() => { @@ -123,7 +123,7 @@ public void Delete_WithSubdirectory_ShouldThrowIOException_AndNotDeleteDirectory ? null : $"'{sut.FullName}'"); - sut.Exists.Should().BeTrue(); + sut.Should().Exist(); FileSystem.Should().HaveDirectory(sut.FullName); } } diff --git a/Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfo/ExistsTests.cs b/Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfo/ExistsTests.cs index aea1b8ef4..92ed6cee7 100644 --- a/Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfo/ExistsTests.cs +++ b/Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfo/ExistsTests.cs @@ -11,7 +11,7 @@ public void Exists_ArbitraryPath_ShouldBeFalse(string path) { IDirectoryInfo sut = FileSystem.DirectoryInfo.New(path); - sut.Exists.Should().BeFalse(); + sut.Should().NotExist(); FileSystem.Should().NotHaveDirectory(sut.FullName); } @@ -21,10 +21,10 @@ public void Exists_ExistedPreviously_ShouldOnlyUpdateOnInitialization(string pat { FileSystem.Directory.CreateDirectory(path); IDirectoryInfo sut = FileSystem.DirectoryInfo.New(path); - sut.Exists.Should().BeTrue(); + sut.Should().Exist(); FileSystem.Directory.Delete(path); - sut.Exists.Should().BeTrue(); + sut.Should().Exist(); FileSystem.Should().NotHaveDirectory(sut.FullName); } @@ -35,7 +35,7 @@ public void Exists_File_ShouldReturnFalse(string path) FileSystem.File.WriteAllText(path, null); IDirectoryInfo sut = FileSystem.DirectoryInfo.New(path); - sut.Exists.Should().BeFalse(); + sut.Should().NotExist(); } [SkippableTheory] @@ -43,10 +43,10 @@ public void Exists_File_ShouldReturnFalse(string path) public void Exists_NotExistedPreviously_ShouldOnlyUpdateOnInitialization(string path) { IDirectoryInfo sut = FileSystem.DirectoryInfo.New(path); - sut.Exists.Should().BeFalse(); + sut.Should().NotExist(); FileSystem.Directory.CreateDirectory(path); - sut.Exists.Should().BeFalse(); + sut.Should().NotExist(); FileSystem.Should().HaveDirectory(sut.FullName); } @@ -56,11 +56,11 @@ public void Exists_ShouldNotChangeOnMoveTo(string path, string destination) { FileSystem.Directory.CreateDirectory(path); IDirectoryInfo sut = FileSystem.DirectoryInfo.New(path); - sut.Exists.Should().BeTrue(); + sut.Should().Exist(); sut.MoveTo(destination); - sut.Exists.Should().BeTrue(); + sut.Should().Exist(); } [SkippableTheory] @@ -68,7 +68,7 @@ public void Exists_ShouldNotChangeOnMoveTo(string path, string destination) public void Exists_ShouldUpdateOnCreateWhenNotNetFramework(string path) { IDirectoryInfo sut = FileSystem.DirectoryInfo.New(path); - sut.Exists.Should().BeFalse(); + sut.Should().NotExist(); sut.Create(); @@ -81,7 +81,7 @@ public void Exists_ShouldUpdateOnDeleteWhenNotNetFramework(string path) { FileSystem.Directory.CreateDirectory(path); IDirectoryInfo sut = FileSystem.DirectoryInfo.New(path); - sut.Exists.Should().BeTrue(); + sut.Should().Exist(); sut.Delete(); @@ -94,7 +94,7 @@ public void Exists_ShouldUpdateOnRecursiveDeleteWhenNotNetFramework(string path) { FileSystem.Directory.CreateDirectory(path); IDirectoryInfo sut = FileSystem.DirectoryInfo.New(path); - sut.Exists.Should().BeTrue(); + sut.Should().Exist(); sut.Delete(true); @@ -107,12 +107,12 @@ public void Exists_ShouldUpdateOnRefresh(string path) { FileSystem.Directory.CreateDirectory(path); IDirectoryInfo sut = FileSystem.DirectoryInfo.New(path); - sut.Exists.Should().BeTrue(); + sut.Should().Exist(); FileSystem.Directory.Delete(path); - sut.Exists.Should().BeTrue(); + sut.Should().Exist(); sut.Refresh(); - sut.Exists.Should().BeFalse(); + sut.Should().NotExist(); } } diff --git a/Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfo/Tests.cs b/Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfo/Tests.cs index 79f716d42..90c270b7e 100644 --- a/Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfo/Tests.cs +++ b/Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfo/Tests.cs @@ -273,9 +273,9 @@ public void Parent_ArbitraryPaths_ShouldNotBeNull(string path1, IDirectoryInfo sut = FileSystem.DirectoryInfo.New(path); sut.Parent.Should().NotBeNull(); - sut.Parent!.Exists.Should().BeFalse(); + sut.Parent!.Should().NotExist(); sut.Parent.Parent.Should().NotBeNull(); - sut.Parent.Parent!.Exists.Should().BeFalse(); + sut.Parent.Parent!.Should().NotExist(); } [SkippableFact] @@ -357,7 +357,7 @@ public void Root_ShouldExist(string path) string expectedRoot = FileTestHelper.RootDrive(); IDirectoryInfo result = FileSystem.DirectoryInfo.New(path); - result.Root.Exists.Should().BeTrue(); + result.Root.Should().Exist(); result.Root.FullName.Should().Be(expectedRoot); } diff --git a/Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfoFactory/Tests.cs b/Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfoFactory/Tests.cs index 82ced765c..7540280a7 100644 --- a/Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfoFactory/Tests.cs +++ b/Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfoFactory/Tests.cs @@ -29,7 +29,7 @@ public void New_ShouldCreateNewDirectoryInfoFromPath(string path) IDirectoryInfo result = FileSystem.DirectoryInfo.New(path); result.ToString().Should().Be(path); - result.Exists.Should().BeFalse(); + result.Should().NotExist(); } [SkippableFact] diff --git a/Tests/Testably.Abstractions.Tests/FileSystem/File/ResolveLinkTargetTests.cs b/Tests/Testably.Abstractions.Tests/FileSystem/File/ResolveLinkTargetTests.cs index 2c7f0e735..f2e63b8e7 100644 --- a/Tests/Testably.Abstractions.Tests/FileSystem/File/ResolveLinkTargetTests.cs +++ b/Tests/Testably.Abstractions.Tests/FileSystem/File/ResolveLinkTargetTests.cs @@ -32,7 +32,7 @@ public void ResolveLinkTarget_AbsolutePath_ShouldFollowSymbolicLink( FileSystem.File.ResolveLinkTarget(path, false); target!.FullName.Should().Be(targetFullPath); - target.Exists.Should().BeTrue(); + target.Should().Exist(); } [SkippableTheory] @@ -52,13 +52,13 @@ public void ResolveLinkTarget_FileWithDifferentCase_ShouldReturnPathToMissingFil if (!Test.RunsOnLinux) { target!.FullName.Should().Be(targetFullPath); - target.Exists.Should().BeTrue(); + target.Should().Exist(); FileSystem.File.ReadAllText(target.FullName).Should().Be(contents); } else { target!.FullName.Should().Be(targetFullPath); - target.Exists.Should().BeFalse(); + target.Should().NotExist(); } } @@ -214,7 +214,7 @@ public void ResolveLinkTarget_RelativePath_ShouldFollowSymbolicLinkUnderWindows( FileSystem.File.ResolveLinkTarget(path, false); target!.FullName.Should().Be(targetFullPath); - target.Exists.Should().BeTrue(); + target.Should().Exist(); } [SkippableTheory] @@ -232,7 +232,7 @@ public void ResolveLinkTarget_TargetDeletedAfterLinkCreation_ShouldReturnNull( target!.FullName.Should().Be(targetFullPath); - target.Exists.Should().BeFalse(); + target.Should().NotExist(); } } #endif diff --git a/Tests/Testably.Abstractions.Tests/FileSystem/FileInfo/CopyToTests.cs b/Tests/Testably.Abstractions.Tests/FileSystem/FileInfo/CopyToTests.cs index 75e628c46..5c1204d45 100644 --- a/Tests/Testably.Abstractions.Tests/FileSystem/FileInfo/CopyToTests.cs +++ b/Tests/Testably.Abstractions.Tests/FileSystem/FileInfo/CopyToTests.cs @@ -26,7 +26,7 @@ public void CopyTo_DestinationExists_ShouldThrowIOException_AndNotCopyFile( exception.Should().BeException( hResult: Test.RunsOnWindows ? -2147024816 : 17); - sut.Exists.Should().BeTrue(); + sut.Should().Exist(); FileSystem.Should().HaveFile(sourceName) .Which.HasContent(sourceContents); FileSystem.Should().HaveFile(destinationName) @@ -48,9 +48,9 @@ public void CopyTo_DestinationExists_WithOverwrite_ShouldOverwriteDestination( IFileInfo result = sut.CopyTo(destinationName, true); - sut.Exists.Should().BeTrue(); + sut.Should().Exist(); sut.FullName.Should().Be(FileSystem.Path.GetFullPath(sourceName)); - result.Exists.Should().BeTrue(); + result.Should().Exist(); result.FullName.Should().Be(FileSystem.Path.GetFullPath(destinationName)); FileSystem.Should().HaveFile(sourceName) .Which.HasContent(sourceContents); @@ -116,8 +116,8 @@ public void CopyTo_ShouldCopyFileWithContent( IFileInfo result = sut.CopyTo(destinationName); sut.FullName.Should().Be(FileSystem.Path.GetFullPath(sourceName)); - sut.Exists.Should().BeTrue(); - result.Exists.Should().BeTrue(); + sut.Should().Exist(); + result.Should().Exist(); result.FullName.Should().Be(FileSystem.Path.GetFullPath(destinationName)); FileSystem.Should().HaveFile(sourceName) .Which.HasContent(contents); diff --git a/Tests/Testably.Abstractions.Tests/FileSystem/FileInfo/CreateTests.cs b/Tests/Testably.Abstractions.Tests/FileSystem/FileInfo/CreateTests.cs index e227f94d9..65ae12900 100644 --- a/Tests/Testably.Abstractions.Tests/FileSystem/FileInfo/CreateTests.cs +++ b/Tests/Testably.Abstractions.Tests/FileSystem/FileInfo/CreateTests.cs @@ -26,23 +26,23 @@ public void Create_ShouldRefreshExistsCacheForCurrentItem_ExceptOnNetFramework(s IFileInfo sut1 = FileSystem.FileInfo.New(path); IFileInfo sut2 = FileSystem.FileInfo.New(path); IFileInfo sut3 = FileSystem.FileInfo.New(path); - sut1.Exists.Should().BeFalse(); - sut2.Exists.Should().BeFalse(); + sut1.Should().NotExist(); + sut2.Should().NotExist(); // Do not call Exists for `sut3` using FileSystemStream stream = sut1.Create(); if (Test.IsNetFramework) { - sut1.Exists.Should().BeFalse(); - sut2.Exists.Should().BeFalse(); - sut3.Exists.Should().BeTrue(); + sut1.Should().NotExist(); + sut2.Should().NotExist(); + sut3.Should().Exist(); } else { - sut1.Exists.Should().BeTrue(); - sut2.Exists.Should().BeFalse(); - sut3.Exists.Should().BeTrue(); + sut1.Should().Exist(); + sut2.Should().NotExist(); + sut3.Should().Exist(); } FileSystem.Should().HaveFile(path); diff --git a/Tests/Testably.Abstractions.Tests/FileSystem/FileInfo/CreateTextTests.cs b/Tests/Testably.Abstractions.Tests/FileSystem/FileInfo/CreateTextTests.cs index 76b8de4f6..56a51ec52 100644 --- a/Tests/Testably.Abstractions.Tests/FileSystem/FileInfo/CreateTextTests.cs +++ b/Tests/Testably.Abstractions.Tests/FileSystem/FileInfo/CreateTextTests.cs @@ -30,14 +30,14 @@ public void CreateText_ShouldRefreshExistsCache( string path, string appendText) { IFileInfo fileInfo = FileSystem.FileInfo.New(path); - fileInfo.Exists.Should().BeFalse(); + fileInfo.Should().NotExist(); using (StreamWriter stream = fileInfo.CreateText()) { stream.Write(appendText); } - fileInfo.Exists.Should().BeTrue(); + fileInfo.Should().Exist(); FileSystem.Should().HaveFile(path); } #else @@ -47,14 +47,14 @@ public void CreateText_ShouldNotRefreshExistsCache( string path, string appendText) { IFileInfo fileInfo = FileSystem.FileInfo.New(path); - fileInfo.Exists.Should().BeFalse(); + fileInfo.Should().NotExist(); using (StreamWriter stream = fileInfo.CreateText()) { stream.Write(appendText); } - fileInfo.Exists.Should().BeFalse(); + fileInfo.Should().NotExist(); FileSystem.Should().HaveFile(path); } #endif diff --git a/Tests/Testably.Abstractions.Tests/FileSystem/FileInfo/DeleteTests.cs b/Tests/Testably.Abstractions.Tests/FileSystem/FileInfo/DeleteTests.cs index e652f59d2..0cafc8dc6 100644 --- a/Tests/Testably.Abstractions.Tests/FileSystem/FileInfo/DeleteTests.cs +++ b/Tests/Testably.Abstractions.Tests/FileSystem/FileInfo/DeleteTests.cs @@ -41,17 +41,17 @@ public void Delete_ShouldRefreshExistsCache_ExceptOnNetFramework(string path) { FileSystem.File.WriteAllText(path, "some content"); IFileInfo sut = FileSystem.FileInfo.New(path); - sut.Exists.Should().BeTrue(); + sut.Should().Exist(); sut.Delete(); if (Test.IsNetFramework) { - sut.Exists.Should().BeTrue(); + sut.Should().Exist(); } else { - sut.Exists.Should().BeFalse(); + sut.Should().NotExist(); } FileSystem.Should().NotHaveFile(path); diff --git a/Tests/Testably.Abstractions.Tests/FileSystem/FileInfo/ExistsTests.cs b/Tests/Testably.Abstractions.Tests/FileSystem/FileInfo/ExistsTests.cs index 90bd0d08c..a3d066369 100644 --- a/Tests/Testably.Abstractions.Tests/FileSystem/FileInfo/ExistsTests.cs +++ b/Tests/Testably.Abstractions.Tests/FileSystem/FileInfo/ExistsTests.cs @@ -12,7 +12,7 @@ public void Exists_Directory_ShouldReturnFalse(string path) FileSystem.Directory.CreateDirectory(path); IFileInfo sut = FileSystem.FileInfo.New(path); - sut.Exists.Should().BeFalse(); + sut.Should().NotExist(); } [SkippableTheory] @@ -20,15 +20,15 @@ public void Exists_Directory_ShouldReturnFalse(string path) public void Exists_ShouldReturnCachedValueUntilRefresh(string path) { IFileInfo sut = FileSystem.FileInfo.New(path); - sut.Exists.Should().BeFalse(); + sut.Should().NotExist(); FileSystem.File.WriteAllText(path, "some content"); - sut.Exists.Should().BeFalse(); + sut.Should().NotExist(); sut.Refresh(); - sut.Exists.Should().BeTrue(); + sut.Should().Exist(); } [SkippableTheory] diff --git a/Tests/Testably.Abstractions.Tests/FileSystem/FileInfo/MoveToTests.cs b/Tests/Testably.Abstractions.Tests/FileSystem/FileInfo/MoveToTests.cs index 3d404d9c3..a3f34df00 100644 --- a/Tests/Testably.Abstractions.Tests/FileSystem/FileInfo/MoveToTests.cs +++ b/Tests/Testably.Abstractions.Tests/FileSystem/FileInfo/MoveToTests.cs @@ -27,7 +27,7 @@ public void MoveTo_DestinationExists_ShouldThrowIOException_AndNotMoveFile( exception.Should().BeException( hResult: Test.RunsOnWindows ? -2147024713 : 17); - sut.Exists.Should().BeTrue(); + sut.Should().Exist(); FileSystem.Should().HaveFile(sourceName) .Which.HasContent(sourceContents); FileSystem.Should().HaveFile(destinationName) @@ -49,7 +49,7 @@ public void MoveTo_DestinationExists_WithOverwrite_ShouldOverwriteDestination( sut.MoveTo(destinationName, true); - sut.Exists.Should().BeTrue(); + sut.Should().Exist(); sut.ToString().Should().Be(destinationName); sut.FullName.Should().Be(FileSystem.Path.GetFullPath(destinationName)); FileSystem.Should().NotHaveFile(sourceName); @@ -116,7 +116,7 @@ public void exception.Should().BeException(hResult: -2147024893); - sut.Exists.Should().BeTrue(); + sut.Should().Exist(); FileSystem.Should().HaveFile(sourceName) .Which.HasContent(sourceContents); FileSystem.Should().NotHaveFile(destinationName); @@ -201,7 +201,7 @@ public void MoveTo_ShouldMoveFileWithContent( sut.MoveTo(destinationName); sut.FullName.Should().Be(FileSystem.Path.GetFullPath(destinationName)); - sut.Exists.Should().BeTrue(); + sut.Should().Exist(); FileSystem.Should().NotHaveFile(sourceName); FileSystem.Should().HaveFile(destinationName) .Which.HasContent(contents); diff --git a/Tests/Testably.Abstractions.Tests/FileSystem/FileInfo/OpenTests.cs b/Tests/Testably.Abstractions.Tests/FileSystem/FileInfo/OpenTests.cs index 3ad27c4f4..06a673ce8 100644 --- a/Tests/Testably.Abstractions.Tests/FileSystem/FileInfo/OpenTests.cs +++ b/Tests/Testably.Abstractions.Tests/FileSystem/FileInfo/OpenTests.cs @@ -159,7 +159,7 @@ public void Open_MissingFileAndCorrectMode_ShouldCreateFile( }); exception.Should().BeNull(); - sut.Exists.Should().BeTrue(); + sut.Should().Exist(); FileSystem.Should().HaveFile(path); } diff --git a/Tests/Testably.Abstractions.Tests/FileSystem/FileInfo/ReplaceTests.cs b/Tests/Testably.Abstractions.Tests/FileSystem/FileInfo/ReplaceTests.cs index f9e784b86..8d8fb58e6 100644 --- a/Tests/Testably.Abstractions.Tests/FileSystem/FileInfo/ReplaceTests.cs +++ b/Tests/Testably.Abstractions.Tests/FileSystem/FileInfo/ReplaceTests.cs @@ -102,7 +102,7 @@ public void Replace_ReadOnly_WithIgnoreMetadataError_ShouldReplaceFile( IFileInfo result = sut.Replace(destinationName, backupName, true); - sut.Exists.Should().BeFalse(); + sut.Should().NotExist(); FileSystem.Should().NotHaveFile(sourceName); result.FullName.Should().Be(FileSystem.Path.GetFullPath(destinationName)); FileSystem.Should().HaveFile(destinationName) @@ -146,7 +146,7 @@ public void else { exception.Should().BeNull(); - sut.Exists.Should().BeFalse(); + sut.Should().NotExist(); FileSystem.Should().NotHaveFile(sourceName); FileSystem.Should().HaveFile(destinationName) .Which.HasContent(sourceContents); @@ -261,7 +261,7 @@ public void Replace_ShouldReplaceFile( IFileInfo result = sut.Replace(destinationName, backupName); - sut.Exists.Should().BeFalse(); + sut.Should().NotExist(); FileSystem.Should().NotHaveFile(sourceName); result.FullName.Should().Be(FileSystem.Path.GetFullPath(destinationName)); FileSystem.Should().HaveFile(destinationName) @@ -334,7 +334,7 @@ public void Replace_SourceLocked_ShouldThrowIOException_OnWindows( if (Test.RunsOnWindows) { exception.Should().BeException(hResult: -2147024864); - sut.Exists.Should().BeTrue(); + sut.Should().Exist(); FileSystem.Should().HaveFile(sourceName) .Which.HasContent(sourceContents); FileSystem.Should().HaveFile(destinationName) @@ -345,7 +345,7 @@ public void Replace_SourceLocked_ShouldThrowIOException_OnWindows( } else { - sut.Exists.Should().BeFalse(); + sut.Should().NotExist(); FileSystem.Should().NotHaveFile(sourceName); FileSystem.Should().HaveFile(destinationName) .Which.HasContent(sourceContents); @@ -394,7 +394,7 @@ public void Replace_WithExistingBackupFile_ShouldIgnoreBackup( IFileInfo result = sut.Replace(destinationName, null); - sut.Exists.Should().BeFalse(); + sut.Should().NotExist(); FileSystem.Should().NotHaveFile(sourceName); result.FullName.Should().Be(FileSystem.Path.GetFullPath(destinationName)); FileSystem.Should().HaveFile(destinationName) @@ -417,7 +417,7 @@ public void Replace_WithoutBackup_ShouldReplaceFile( IFileInfo result = sut.Replace(destinationName, null); - sut.Exists.Should().BeFalse(); + sut.Should().NotExist(); FileSystem.Should().NotHaveFile(sourceName); result.FullName.Should().Be(FileSystem.Path.GetFullPath(destinationName)); FileSystem.Should().HaveFile(destinationName) diff --git a/Tests/Testably.Abstractions.Tests/FileSystem/FileInfoFactory/Tests.cs b/Tests/Testably.Abstractions.Tests/FileSystem/FileInfoFactory/Tests.cs index 22b085c51..7b7980a32 100644 --- a/Tests/Testably.Abstractions.Tests/FileSystem/FileInfoFactory/Tests.cs +++ b/Tests/Testably.Abstractions.Tests/FileSystem/FileInfoFactory/Tests.cs @@ -37,7 +37,7 @@ public void New_ShouldCreateNewFileInfoFromPath(string path) IFileInfo result = FileSystem.FileInfo.New(path); result.ToString().Should().Be(path); - result.Exists.Should().BeFalse(); + result.Should().NotExist(); } [SkippableTheory] diff --git a/Tests/Testably.Abstractions.Tests/FileSystem/FileSystemInfo/ResolveLinkTargetTests.cs b/Tests/Testably.Abstractions.Tests/FileSystem/FileSystemInfo/ResolveLinkTargetTests.cs index 72709cad0..f5d867e5d 100644 --- a/Tests/Testably.Abstractions.Tests/FileSystem/FileSystemInfo/ResolveLinkTargetTests.cs +++ b/Tests/Testably.Abstractions.Tests/FileSystem/FileSystemInfo/ResolveLinkTargetTests.cs @@ -36,12 +36,12 @@ public void ResolveLinkTarget_FileWithDifferentCase_ShouldReturnPathToMissingFil target!.FullName.Should().Be(targetFullPath); if (!Test.RunsOnLinux) { - target.Exists.Should().BeTrue(); + target.Should().Exist(); FileSystem.File.ReadAllText(target.FullName).Should().Be(contents); } else { - target.Exists.Should().BeFalse(); + target.Should().NotExist(); } } @@ -153,7 +153,7 @@ public void ResolveLinkTarget_ShouldFollowSymbolicLink( IFileSystemInfo? target = fileInfo.ResolveLinkTarget(false); target!.FullName.Should().Be(targetFullPath); - target.Exists.Should().BeTrue(); + target.Should().Exist(); } [SkippableTheory] @@ -170,7 +170,7 @@ public void ResolveLinkTarget_TargetDeletedAfterLinkCreation_ShouldReturnNull( IFileSystemInfo? target = fileInfo.ResolveLinkTarget(false); target!.FullName.Should().Be(targetFullPath); - target.Exists.Should().BeFalse(); + target.Should().NotExist(); } } #endif