From 2e2100c42b62a795d51477f535e0f4cdcc163efb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Valentin=20Breu=C3=9F?= Date: Sat, 11 Jul 2026 17:58:21 +0200 Subject: [PATCH] fix: address analyzer code smells in compression package Switch the S2325 suppression to CA1822 in FileSystemExtensions (S2325 is deprecated in favor of the Roslyn rule) and remove the unnecessary partial modifier from the two compression ExtensionTests classes. --- .../Testably.Abstractions.Compression/FileSystemExtensions.cs | 4 ++-- .../ZipArchive/ExtensionTests.cs | 2 +- .../ZipArchiveEntry/ExtensionTests.cs | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Source/Testably.Abstractions.Compression/FileSystemExtensions.cs b/Source/Testably.Abstractions.Compression/FileSystemExtensions.cs index 894355f5..616bbba2 100644 --- a/Source/Testably.Abstractions.Compression/FileSystemExtensions.cs +++ b/Source/Testably.Abstractions.Compression/FileSystemExtensions.cs @@ -6,7 +6,7 @@ /// public static class FileSystemExtensions { - #pragma warning disable S2325 // False positive: an extension property cannot be static + #pragma warning disable CA1822 // False positive: an extension property cannot be static /// extension(IFileSystem fileSystem) { @@ -22,5 +22,5 @@ public IZipArchiveFactory ZipArchive public IZipFile ZipFile => new ZipFileWrapper(fileSystem); } - #pragma warning restore S2325 + #pragma warning restore CA1822 } diff --git a/Tests/Testably.Abstractions.Compression.Tests/ZipArchive/ExtensionTests.cs b/Tests/Testably.Abstractions.Compression.Tests/ZipArchive/ExtensionTests.cs index 8a9a6cf4..7d7e82bf 100644 --- a/Tests/Testably.Abstractions.Compression.Tests/ZipArchive/ExtensionTests.cs +++ b/Tests/Testably.Abstractions.Compression.Tests/ZipArchive/ExtensionTests.cs @@ -6,7 +6,7 @@ namespace Testably.Abstractions.Compression.Tests.ZipArchive; [FileSystemTests] -public partial class ExtensionTests(FileSystemTestData testData) : FileSystemTestBase(testData) +public class ExtensionTests(FileSystemTestData testData) : FileSystemTestBase(testData) { [Test] [Arguments("2000-01-01T12:14:15")] diff --git a/Tests/Testably.Abstractions.Compression.Tests/ZipArchiveEntry/ExtensionTests.cs b/Tests/Testably.Abstractions.Compression.Tests/ZipArchiveEntry/ExtensionTests.cs index b7b3ac7f..81835cd0 100644 --- a/Tests/Testably.Abstractions.Compression.Tests/ZipArchiveEntry/ExtensionTests.cs +++ b/Tests/Testably.Abstractions.Compression.Tests/ZipArchiveEntry/ExtensionTests.cs @@ -6,7 +6,7 @@ namespace Testably.Abstractions.Compression.Tests.ZipArchiveEntry; [FileSystemTests] -public partial class ExtensionTests(FileSystemTestData testData) : FileSystemTestBase(testData) +public class ExtensionTests(FileSystemTestData testData) : FileSystemTestBase(testData) { [Test] public async Task