refactor: fix ReSharper code issues (#542)

- Fix "XML no root tag defined"
- Fix Spelling issues
- Fix Formatting
- Simplify Dictionary Lookup
- Fix grammar issues
- Fix redundancies in code
- Fix potential code quality issues
- Add Async overload for CancellationTokenSource.Cancel
- Implement Language Usage Opportunities: 
- Use collection expression syntax
- Use deconstruction to swap variables
- Use primary constructor in tests

Author: vbreuss

.github/coverage-settings.xml

@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
-<!-- https://learn.microsoft.com/en-us/dotnet/core/additional-tools/dotnet-coverage#settings -->
 
 <Configuration>
+	<!-- https://learn.microsoft.com/en-us/dotnet/core/additional-tools/dotnet-coverage#settings -->
 	<CodeCoverage>
 		<Attributes>
 			<Exclude>

Source/Testably.Abstractions.Compression/Internal/ZipUtilities.cs

@@ -180,9 +180,9 @@ internal static void CreateFromDirectory(
 				else if (file is IDirectoryInfo directoryInfo &&
 				         directoryInfo.GetFileSystemInfos().Length == 0)
 				{
-#pragma warning disable CA1845
+					#pragma warning disable CA1845
 					string entryName = file.FullName.Substring(basePath.Length + 1) + "/";
-#pragma warning restore CA1845
+					#pragma warning restore CA1845
 					archive.CreateEntry(entryName);
 				}
 			}

Source/Testably.Abstractions.Interface/Usings.cs

@@ -1,5 +1,3 @@
 #if NETSTANDARD2_0 || NETSTANDARD2_1
 global using Testably.Abstractions.Polyfills;
-#else
-global using System.Runtime.Versioning;
 #endif

Source/Testably.Abstractions.Testing/FileSystem/DirectoryInfoMock.cs

@@ -89,7 +89,7 @@ public IDirectoryInfo CreateSubdirectory(string path)
 			_fileSystem.Storage.GetLocation(
 				_fileSystem.Execute.Path.Combine(FullName, path
 					.EnsureValidFormat(_fileSystem, nameof(path),
-						_fileSystem.Execute.IsWindows && !_fileSystem.Execute.IsNetFramework))),
+						_fileSystem.Execute is { IsWindows: true, IsNetFramework: false }))),
 			_fileSystem);
 		directory.Create();
 		return directory;

Source/Testably.Abstractions.Testing/FileSystem/DriveInfoMock.cs

@@ -183,6 +183,7 @@ public string VolumeLabel
 			using IDisposable registration =
 				RegisterProperty(nameof(VolumeLabel), PropertyAccess.Set);
 
+			// ReSharper disable once ConstantNullCoalescingCondition
 			_volumeLabel = value ?? _volumeLabel;
 			_fileSystem.Execute.NotOnWindows(
 				() => throw ExceptionFactory.OperationNotSupportedOnThisPlatform());

Source/Testably.Abstractions.Testing/FileSystem/FileSystemWatcherMock.cs

@@ -27,7 +27,7 @@ internal sealed class FileSystemWatcherMock : Component, IFileSystemWatcher
 	private IDisposable? _changeHandler;
 	private bool _enableRaisingEvents;
 	private readonly MockFileSystem _fileSystem;
-	private readonly Collection<string> _filters = new();
+	private readonly Collection<string> _filters = [];
 	private bool _includeSubdirectories;
 	private int _internalBufferSize = 8192;
 	private bool _isInitializing;

Source/Testably.Abstractions.Testing/FileSystem/INotificationHandler.cs

@@ -16,7 +16,7 @@ public interface INotificationHandler : IFileSystemEntity
 	///     (optional) A predicate used to filter which callbacks should be notified.<br />
 	///     If set to <see langword="null" /> (default value) all callbacks are notified.
 	/// </param>
-	/// <returns>An <see cref="Notification.IAwaitableCallback{ChangeDescription}" /> to un-register the callback on dispose.</returns>
+	/// <returns>A <see cref="Notification.IAwaitableCallback{ChangeDescription}" /> to un-register the callback on dispose.</returns>
 	Notification.IAwaitableCallback<ChangeDescription> OnEvent(
 		Action<ChangeDescription>? notificationCallback = null,
 		Func<ChangeDescription, bool>? predicate = null);

Source/Testably.Abstractions.Testing/FileSystemTypes.cs

@@ -3,7 +3,7 @@
 namespace Testably.Abstractions.Testing;
 
 /// <summary>
-///     Determines the type of an entry in the <see cref="MockFileSystem" />.
+///     Determines the entry's type in the <see cref="MockFileSystem" />.
 /// </summary>
 [Flags]
 public enum FileSystemTypes

Source/Testably.Abstractions.Testing/Helpers/EnumerationOptionsHelper.cs

@@ -145,13 +145,7 @@ private static bool MatchPattern(Execute execute,
 	/// </summary>
 	private static string SimplifyExpression(Execute execute, string searchString)
 	{
-		char[] unixEscapeChars =
-		{
-			'\\',
-			'"',
-			'<',
-			'>'
-		};
+		char[] unixEscapeChars = ['\\', '"', '<', '>'];
 		if (string.Equals(searchString, DefaultSearchPattern, StringComparison.Ordinal))
 		{
 			return searchString;

Source/Testably.Abstractions.Testing/Helpers/Execute.NativePath.cs

@@ -1,8 +1,8 @@
-using System.Diagnostics.CodeAnalysis;
-using System.IO;
-#if FEATURE_SPAN
+#if FEATURE_SPAN
 using System;
 #endif
+using System.Diagnostics.CodeAnalysis;
+using System.IO;
 #if FEATURE_FILESYSTEM_NET7
 using Testably.Abstractions.Testing.Storage;
 #endif