Kafkahandler: Handle missing bootstrap servers #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 12, 2024 09:05
|
@language-shprt can you please review this as well. |
added 2 commits
April 16, 2024 09:43
| @@ -131,7 +131,7 @@ async def _render_template(self, template, params): | |||
| if not template.startswith('/Templates/Attachment/'): | |||
| raise ASABIrisError( | |||
| ErrorCode.INVALID_PATH, | |||
| tech_message="Cannot render attachment: Invalid template path for '{}'. Move it to '/Templates/Attachment/'.".format(template), | |||
| tech_message="Failed to render the attachment. Reason: The template path '{}' is not valid. Please ensure the template is located in the '/Templates/Attachment/' directory for proper processing.", | |||
There was a problem hiding this comment.
The template path '{}' piece won't show any path. Add .format()?
| exit() | ||
| except (configparser.NoOptionError, ValueError) as e: | ||
| L.warning("Configuration issue: {}".format(e)) | ||
| return None # Returns None on |
There was a problem hiding this comment.
I am sorry, but I don't understand that comment here = I already see it returns None from code, but "on" doesn't clear that case for me... Maybe it is ok and I am just not familiar with the code :)
ateska
approved these changes
May 9, 2024
There was a problem hiding this comment.
ok from my side
please clarify questions of @language-shprt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.