Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when adding a layer from a wms, discovered via cssw-catalog, all layers are added at once #7320

Open
pvgenuchten opened this issue Nov 20, 2024 · 4 comments
Assignees

Comments

@pvgenuchten
Copy link

pvgenuchten commented Nov 20, 2024

I'm trying to find out what happens, so let me describe how I reproduce the issue

At https://rwanda.lsc-hubs.org/map/ we host a recent version of Terria, When opening the CSW catalog in explore data and search for 'slope'

Image

Image

Then click + button on any layer

Expected: Single layer is added to map

Instead: All layers of that WMS are requested in a single map request, causing slow response/heavy server load and a large numbers of legends being displayed

The challenge is that the metadata does not (properly) identify which of the layers in the WMS are the relevant one, so terria decides to add all of them, this aspect is also mentioned in #6866, in stead suggestion could be to add the top 5 layers only? Or alternatively, move the + button to a select layer section in:

Image

@zoran995
Copy link
Collaborator

Hi @pvgenuchten, it might be a better approach to have the possibility to specify the handling of wms layers as wms-group or wms that way it would you would just specify the proper value and catalog and have the layers as a wms-group. I have posted the same idea as the comment on #6866 so let's see first what Nick thinks about it and if it is even possible

@sidneygijzen
Copy link
Contributor

hi @zoran995

@pvgenuchten asked me to look into this issue (and the linked issue 6866). I've been reading through both issues. I think a good first step would be implement Paul's suggestion of limiting the maximum WMS layers to be added in case no valid WMS urls are found. This stops resource-intensive WMS requests. I would like to try and prepare a PR for this.

However, I noticed you are assigned to this issue, so I wanted to check-in first with you. If I would try to prepare a PR with the above-mentioned suggestion would this disrupt your work?

@zoran995
Copy link
Collaborator

Hi, I haven't started looking into this yet.

@sidneygijzen
Copy link
Contributor

hi @zoran995

Thanks for your prompt response. I will have a look then at preparing the PR mentioned above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants