You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At the moment we have about 90% of Mixins using XMixin.XMixin:
namespaceTableMixin{exportinterfaceTableMixinextendsInstanceType<ReturnType<typeofTableMixin>>{}exportfunctionisMixedInto(model: any): model is TableMixin{returnmodel&&model.hasTableMixin;}}
and 10% using XMixin.Instance:
namespaceTileErrorHandlerMixin{exportinterfaceInstanceextendsInstanceType<ReturnType<typeofTileErrorHandlerMixin>>{}exportfunctionisMixedInto(model: any): model is Instance{returnmodel?.hasTileErrorHandlerMixin;}}
Note that removing the mixin name from the instance type name shouldn't make IDE types worse as the namespace is still displayed:
We should decide on a naming scheme, document it and apply it universally. I prefer XMixin.Instance because it's more descriptive. It's the instance type of XMixin
The text was updated successfully, but these errors were encountered:
At the moment we have about 90% of Mixins using
XMixin.XMixin
:and 10% using
XMixin.Instance
:Note that removing the mixin name from the instance type name shouldn't make IDE types worse as the namespace is still displayed:
We should decide on a naming scheme, document it and apply it universally. I prefer
XMixin.Instance
because it's more descriptive. It's the instance type of XMixinThe text was updated successfully, but these errors were encountered: