Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model architecture: Add error boundaries in the React UI #3487

Open
Tracked by #5677
kring opened this issue Jun 12, 2019 · 2 comments
Open
Tracked by #5677

Model architecture: Add error boundaries in the React UI #3487

kring opened this issue Jun 12, 2019 · 2 comments
Assignees
@tephenavies
Milestone
Prioritized New M...

Comments

@kring
Copy link
Member

kring commented Jun 12, 2019

Especially in charts, an error can crash the whole the UI. Errors in charts can happen through a misconfigured featureInfoTemplate, so it's not just a developer error.
@kring kring added the Version 8 formerly MobX label Jun 12, 2019
@soyarsauce
Copy link
Contributor

@kring an aside I started something along this in the routing branch
https://github.com/TerriaJS/terriajs/blob/1757-new-routing/lib/ReactViews/ErrorBoundary/ErrorBoundary.jsx
https://github.com/TerriaJS/terriajs/blob/1757-new-routing/lib/ReactViews/Preview/MappablePreview.jsx

@tephenavies tephenavies self-assigned this Apr 12, 2021
@tephenavies
Copy link
Member

Implement after #4961 lands, which brings in the React components mentioned above.

@AnaBelgun AnaBelgun mentioned this issue Jul 1, 2021
Closed
33 tasks
@wibily wibily removed Version 8 formerly MobX V8-release labels Jul 7, 2021
@AnaBelgun AnaBelgun mentioned this issue Jul 26, 2021
Open
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tephenavies tephenavies

Labels
None yet
Projects
None yet
Milestone
Prioritized New Model Architecture Is...
Development

No branches or pull requests
6 participants
@kring @wibily @nf-s @soyarsauce @tephenavies @AnaBelgun